src/compiler/node-properties.cc - Issue 2050813003: [turbofan] Introduce CheckIf node (deopt without explicit frame state).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/node-properties.cc

Issue 2050813003: [turbofan] Introduce CheckIf node (deopt without explicit frame state). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Rename Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/node-properties.cc

diff --git a/src/compiler/node-properties.cc b/src/compiler/node-properties.cc

index 9451df8566dadbb952d43aa88e36171155e896ad..dc33d603371801daaf7566c9a96dfe6841428465 100644

--- a/src/compiler/node-properties.cc

+++ b/src/compiler/node-properties.cc

@@ -215,7 +215,8 @@ void NodeProperties::ReplaceUses(Node* node, Node* value, Node* effect,

DCHECK_NOT_NULL(exception);

edge.UpdateTo(exception);

} else {

- UNREACHABLE();

+ DCHECK_NOT_NULL(success);

+ edge.UpdateTo(success);

}

} else if (IsEffectEdge(edge)) {

DCHECK_NOT_NULL(effect);

« no previous file with comments | « src/compiler/effect-control-linearizer.cc ('k') | src/compiler/opcodes.h » ('j') | no next file with comments »