Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 1914763002: QuotaTracker: Use 'raw' string as key for origin (Closed)

Created:
4 years, 8 months ago by jsbell
Modified:
4 years, 8 months ago
Reviewers:
michaeln
CC:
chromium-reviews, blink-reviews, haraken
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

QuotaTracker: Use 'raw' string as key for origin Prior to r382660 the QuotaTracker API took DatabaseIdentifiers, and a serialization was used as the key in maps. This was changed to take SecurityOrigins instead and the serialization via toString(). This introduced additional special cases e.g. "null" for file:// origins in some cases, leading to mismatches between setting and lookup in the map depending on when the SecurityOrigin was minted. To fix, use toRawString() which matches the old behavior without special cases. BUG=604811 R=michaeln@chromium.org Committed: https://crrev.com/976f8fa83bf90a5983af3ca8a6e74d34044b93ff Cr-Commit-Position: refs/heads/master@{#389607}

Patch Set 1 #

Patch Set 2 : Added unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -7 lines) Patch
M third_party/WebKit/Source/modules/modules.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/QuotaTracker.cpp View 2 chunks +7 lines, -7 lines 0 comments Download
A third_party/WebKit/Source/modules/webdatabase/QuotaTrackerTest.cpp View 1 1 chunk +58 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jsbell
michaeln@ - please take a look?
4 years, 8 months ago (2016-04-22 22:14:14 UTC) #1
michaeln
lgtm!!
4 years, 8 months ago (2016-04-25 20:18:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1914763002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1914763002/20001
4 years, 8 months ago (2016-04-25 20:50:10 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-25 23:29:03 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 23:32:05 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/976f8fa83bf90a5983af3ca8a6e74d34044b93ff
Cr-Commit-Position: refs/heads/master@{#389607}

Powered by Google App Engine
This is Rietveld 408576698