Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: src/builtins.cc

Issue 2050733004: Add UseCounter for Date.parse's legacy parse heuristics. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/v8.h ('k') | src/dateparser.h » ('j') | src/dateparser-inl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/builtins.cc
diff --git a/src/builtins.cc b/src/builtins.cc
index fcf0c6deab2f04bd593a95b8a8274a819768be31..0d5bac6d504292b6e164e0d7506c2f41de5e42a5 100644
--- a/src/builtins.cc
+++ b/src/builtins.cc
@@ -3291,11 +3291,9 @@ double ParseDateTimeString(Handle<String> str) {
String::FlatContent str_content = str->GetFlatContent();
bool result;
if (str_content.IsOneByte()) {
- result = DateParser::Parse(str_content.ToOneByteVector(), *tmp,
- isolate->unicode_cache());
+ result = DateParser::Parse(isolate, str_content.ToOneByteVector(), *tmp);
} else {
- result = DateParser::Parse(str_content.ToUC16Vector(), *tmp,
- isolate->unicode_cache());
+ result = DateParser::Parse(isolate, str_content.ToUC16Vector(), *tmp);
}
if (!result) return std::numeric_limits<double>::quiet_NaN();
double const day = MakeDay(tmp->get(0)->Number(), tmp->get(1)->Number(),
« no previous file with comments | « include/v8.h ('k') | src/dateparser.h » ('j') | src/dateparser-inl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698