Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 2050473005: Adding float/double support in CopyToReg (Closed)

Created:
4 years, 6 months ago by mohit.bhakkad
Modified:
4 years, 6 months ago
CC:
native-client-reviews_googlegroups.com, jaydeep.patil, rich.fuhler_imgtec.com, srdjan.obucina_imgtec.com, sagar.thakur
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Changing the wrong condition #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/IceTargetLoweringMIPS32.cpp View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
mohit.bhakkad
4 years, 6 months ago (2016-06-09 06:06:01 UTC) #3
Jim Stichnoth
lgtm
4 years, 6 months ago (2016-06-09 22:05:39 UTC) #4
Jim Stichnoth
4 years, 6 months ago (2016-06-09 22:06:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b684f2b7a374b08eaf45e4b87824d3e9bf0be561 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698