Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Issue 2050443002: Remove dead code in strong mode's warnings for null literals (Closed)

Created:
4 years, 6 months ago by Jennifer Messerly
Modified:
4 years, 6 months ago
Reviewers:
Leaf
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove dead code in strong mode's warnings for null literals This code should no longer be reachable. I think it was part of our early non-null primitive type experimentation. (Currently `null` literal is treated as bottom, so it should never be a downcast if casting from null.) R=leafp@google.com Committed: https://github.com/dart-lang/sdk/commit/61a2bb4fdcd4f82693f2038f2eef645639970d04

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M pkg/analyzer/lib/src/task/strong/info.dart View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jennifer Messerly
4 years, 6 months ago (2016-06-07 20:55:01 UTC) #3
Leaf
lgtm
4 years, 6 months ago (2016-06-07 20:59:33 UTC) #4
Jennifer Messerly
4 years, 6 months ago (2016-06-07 21:03:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
61a2bb4fdcd4f82693f2038f2eef645639970d04 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698