Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: pkg/analyzer/lib/src/task/strong/info.dart

Issue 2050443002: Remove dead code in strong mode's warnings for null literals (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /// Defines static information collected by the type checker and used later by 5 /// Defines static information collected by the type checker and used later by
6 /// emitters to generate code. 6 /// emitters to generate code.
7 // TODO(jmesserly): this was ported from package:dev_compiler, and needs to be 7 // TODO(jmesserly): this was ported from package:dev_compiler, and needs to be
8 // refactored to fit into analyzer. 8 // refactored to fit into analyzer.
9 library analyzer.src.task.strong.info; 9 library analyzer.src.task.strong.info;
10 10
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 String get message => 'Unsound implicit cast from {0} to {1}'; 85 String get message => 'Unsound implicit cast from {0} to {1}';
86 86
87 /// Factory to create correct DownCast variant. 87 /// Factory to create correct DownCast variant.
88 static StaticInfo create(StrongTypeSystemImpl rules, Expression expression, 88 static StaticInfo create(StrongTypeSystemImpl rules, Expression expression,
89 DartType fromType, DartType toType) { 89 DartType fromType, DartType toType) {
90 // toT <:_R fromT => to <: fromT 90 // toT <:_R fromT => to <: fromT
91 // NB: classes with call methods are subtypes of function 91 // NB: classes with call methods are subtypes of function
92 // types, but the function type is not assignable to the class 92 // types, but the function type is not assignable to the class
93 assert(toType.isSubtypeOf(fromType) || fromType.isAssignableTo(toType)); 93 assert(toType.isSubtypeOf(fromType) || fromType.isAssignableTo(toType));
94 94
95 // Handle null call specially.
96 if (expression is NullLiteral) {
97 // TODO(vsm): Create a NullCast for this once we revisit nonnullability.
98 return new DownCastImplicit(rules, expression, fromType, toType);
99 }
100
101 // Inference "casts": 95 // Inference "casts":
102 if (expression is Literal || expression is FunctionExpression) { 96 if (expression is Literal || expression is FunctionExpression) {
103 // fromT should be an exact type - this will almost certainly fail at 97 // fromT should be an exact type - this will almost certainly fail at
104 // runtime. 98 // runtime.
105 return new StaticTypeError(rules, expression, toType); 99 return new StaticTypeError(rules, expression, toType);
106 } 100 }
107 101
108 if (expression is InstanceCreationExpression) { 102 if (expression is InstanceCreationExpression) {
109 ConstructorElement e = expression.staticElement; 103 ConstructorElement e = expression.staticElement;
110 if (e == null || !e.isFactory) { 104 if (e == null || !e.isFactory) {
(...skipping 427 matching lines...) Expand 10 before | Expand all | Expand 10 after
538 super(expression); 532 super(expression);
539 533
540 @override 534 @override
541 List<Object> get arguments => [node, baseType, expectedType]; 535 List<Object> get arguments => [node, baseType, expectedType];
542 @override 536 @override
543 String get message => 'Type check failed: {0} ({1}) is not of type {2}'; 537 String get message => 'Type check failed: {0} ({1}) is not of type {2}';
544 538
545 @override 539 @override
546 String get name => 'STRONG_MODE_STATIC_TYPE_ERROR'; 540 String get name => 'STRONG_MODE_STATIC_TYPE_ERROR';
547 } 541 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698