Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2050403002: Fix glDraw*Indirect prototypes (Closed)

Created:
4 years, 6 months ago by csmartdalton
Modified:
4 years, 6 months ago
Reviewers:
bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : missed a file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M include/gpu/gl/GrGLFunctions.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLTestInterface.h View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
csmartdalton
4 years, 6 months ago (2016-06-09 20:57:41 UTC) #2
csmartdalton
4 years, 6 months ago (2016-06-09 20:58:01 UTC) #4
bsalomon
lgtm
4 years, 6 months ago (2016-06-10 00:27:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2050403002/1
4 years, 6 months ago (2016-06-10 00:35:14 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/9025) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, ...
4 years, 6 months ago (2016-06-10 00:38:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2050403002/2
4 years, 6 months ago (2016-06-10 02:28:25 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 02:42:41 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:2) as
https://skia.googlesource.com/skia/+/739bbb2dadbb9f1c37db0a2afa3709ae132d007a

Powered by Google App Engine
This is Rietveld 408576698