Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(812)

Issue 205033010: Remove --enable-accelerated-filters flag, Blink-side. (Closed)

Created:
6 years, 9 months ago by Stephen White
Modified:
6 years, 9 months ago
CC:
blink-reviews, eae+blinkwatch, fs, kouhei+svg_chromium.org, rwlbuis, jamesr, krit, bemjb+rendering_chromium.org, dsinclair, abarth-chromium, danakj, dglazkov+blink, Rik, jchaffraix+rendering, rune+blink, zoltan1, jbroman, gyuyoung.kim_webkit.org, leviw+renderwatch, blink-layers+watch_chromium.org, ed+blinkwatch_opera.com, f(malita), Stephen Chennney
Visibility:
Public.

Description

Remove --enable-accelerated-filters flag, Blink-side. This removes all the support code, and the legacy Blink-side accelerated filter rendering. Acceleration of SVG-on-SVG filters will be achieved instead with deferred filters, impl-side painting and Ganesh rasterization. (CSS filters have their own layer-based accelerated rendering path, implemented in the compositor, which is already shipping.) NOTE: this change depends on the Chrome-side change https://codereview.chromium.org/205923005/, which must land first. BUG=196562 R=junov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169707

Patch Set 1 #

Patch Set 2 : Remove a now-spurious #include #

Patch Set 3 : Take AcceleratedImageBufferSurface behind the woodshed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -313 lines) Patch
M Source/core/frame/Settings.in View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/FilterEffectRenderer.cpp View 2 chunks +1 line, -8 lines 0 comments Download
M Source/core/rendering/RenderLayer.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceFilter.cpp View 1 3 chunks +3 lines, -12 lines 0 comments Download
M Source/platform/blink_platform.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M Source/platform/graphics/filters/FEBlend.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/graphics/filters/FEBlend.cpp View 1 chunk +0 lines, -37 lines 0 comments Download
M Source/platform/graphics/filters/FEDisplacementMap.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/graphics/filters/FEDisplacementMap.cpp View 1 chunk +0 lines, -42 lines 0 comments Download
M Source/platform/graphics/filters/FELighting.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/graphics/filters/FELighting.cpp View 1 chunk +0 lines, -30 lines 0 comments Download
M Source/platform/graphics/filters/FETile.cpp View 2 chunks +1 line, -7 lines 0 comments Download
M Source/platform/graphics/filters/FETurbulence.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/graphics/filters/FETurbulence.cpp View 1 chunk +0 lines, -18 lines 0 comments Download
M Source/platform/graphics/filters/Filter.h View 3 chunks +1 line, -6 lines 0 comments Download
M Source/platform/graphics/filters/FilterEffect.cpp View 3 chunks +2 lines, -9 lines 0 comments Download
D Source/platform/graphics/gpu/AcceleratedImageBufferSurface.h View 1 2 1 chunk +0 lines, -60 lines 0 comments Download
D Source/platform/graphics/gpu/AcceleratedImageBufferSurface.cpp View 1 2 1 chunk +0 lines, -69 lines 0 comments Download
M Source/web/WebSettingsImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/web/WebSettingsImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M public/web/WebSettings.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 22 (0 generated)
Stephen White
PTAL. Thanks!
6 years, 9 months ago (2014-03-20 18:13:14 UTC) #1
Justin Novosad
On 2014/03/20 18:13:14, Stephen White wrote: > PTAL. Thanks! Yay for deleting code! lgtm, but ...
6 years, 9 months ago (2014-03-20 18:30:05 UTC) #2
Stephen White
On 2014/03/20 18:30:05, junov wrote: > On 2014/03/20 18:13:14, Stephen White wrote: > > PTAL. ...
6 years, 9 months ago (2014-03-20 18:34:54 UTC) #3
Justin Novosad
On 2014/03/20 18:34:54, Stephen White wrote: > On 2014/03/20 18:30:05, junov wrote: > > On ...
6 years, 9 months ago (2014-03-20 18:46:57 UTC) #4
Stephen White
The CQ bit was checked by senorblanco@chromium.org
6 years, 9 months ago (2014-03-20 20:52:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/senorblanco@chromium.org/205033010/40001
6 years, 9 months ago (2014-03-20 20:52:20 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 20:55:14 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 9 months ago (2014-03-20 20:55:14 UTC) #8
pdr.
The CQ bit was checked by pdr@chromium.org
6 years, 9 months ago (2014-03-20 20:58:59 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/senorblanco@chromium.org/205033010/40001
6 years, 9 months ago (2014-03-20 20:59:03 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 21:04:05 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 9 months ago (2014-03-20 21:04:05 UTC) #12
pdr.
On 2014/03/20 21:04:05, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 9 months ago (2014-03-20 21:09:34 UTC) #13
abarth-chromium
rslgtm!
6 years, 9 months ago (2014-03-20 21:32:17 UTC) #14
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 9 months ago (2014-03-20 21:32:21 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/senorblanco@chromium.org/205033010/40001
6 years, 9 months ago (2014-03-20 21:32:26 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 21:46:49 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-20 21:46:53 UTC) #18
Stephen White
The CQ bit was checked by senorblanco@chromium.org
6 years, 9 months ago (2014-03-20 22:10:22 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/senorblanco@chromium.org/205033010/40001
6 years, 9 months ago (2014-03-20 22:10:24 UTC) #20
Stephen White
Thanks, pdr!
6 years, 9 months ago (2014-03-20 22:22:39 UTC) #21
commit-bot: I haz the power
6 years, 9 months ago (2014-03-20 23:14:57 UTC) #22
Message was sent while issue was closed.
Change committed as 169707

Powered by Google App Engine
This is Rietveld 408576698