third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h - Issue 2050123002: Remove OwnPtr from Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h

Issue 2050123002: Remove OwnPtr from Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: First attempt to land. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/web/RemoteFrameClientImpl.cpp ('k') | third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h

diff --git a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h

index 52d6d4a73b574cb9dcc9aac00f3e86afb6011310..e9ca382c4c1cadcc01f6d3b784e7a8beda1ff539 100644

--- a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h

+++ b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h

@@ -34,7 +34,7 @@

#include "modules/serviceworkers/ServiceWorkerGlobalScopeClient.h"

#include "public/platform/modules/serviceworker/WebServiceWorkerClientsInfo.h"

#include "public/platform/modules/serviceworker/WebServiceWorkerSkipWaitingCallbacks.h"

-#include "wtf/OwnPtr.h"

+#include <memory>

namespace blink {

@@ -65,8 +65,8 @@ public:

void didHandleNotificationCloseEvent(int eventID, WebServiceWorkerEventResult) override;

void didHandlePushEvent(int pushEventID, WebServiceWorkerEventResult) override;

void didHandleSyncEvent(int syncEventID, WebServiceWorkerEventResult) override;

- void postMessageToClient(const WebString& clientUUID, const WebString& message, PassOwnPtr<WebMessagePortChannelArray>) override;

- void postMessageToCrossOriginClient(const WebCrossOriginServiceWorkerClient&, const WebString& message, PassOwnPtr<WebMessagePortChannelArray>) override;

+ void postMessageToClient(const WebString& clientUUID, const WebString& message, std::unique_ptr<WebMessagePortChannelArray>) override;

+ void postMessageToCrossOriginClient(const WebCrossOriginServiceWorkerClient&, const WebString& message, std::unique_ptr<WebMessagePortChannelArray>) override;

void skipWaiting(WebServiceWorkerSkipWaitingCallbacks*) override;

void claim(WebServiceWorkerClientsClaimCallbacks*) override;

void focus(const WebString& clientUUID, WebServiceWorkerClientCallbacks*) override;