Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Issue 2050033002: Revert of Remove enable/disable wheel gestures setting. (Closed)

Created:
4 years, 6 months ago by scheib
Modified:
4 years, 6 months ago
CC:
cc-bugs_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dtapuska+chromiumwatch_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, nasko+codewatch_chromium.org, nona+watch_chromium.org, Peter Beverloo, piman+watch_chromium.org, shuchen+watch_chromium.org, James Su, tdresser+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@can_scroll_remove
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove enable/disable wheel gestures setting. (patchset #3 id:40001 of https://codereview.chromium.org/2047093002/ ) Reason for revert: Caused RenderWidgetHostViewMacTest.IgnoreEmptyUnhandledWheelEventWithWheelGestures failure on build: https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20(dbg)/builds/25325 See https://findit-for-me.appspot.com/build-failure?url=https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20(dbg)/builds/25325 Test output: """ [ RUN ] RenderWidgetHostViewMacTest.IgnoreEmptyUnhandledWheelEventWithWheelGestures ../../content/browser/renderer_host/render_widget_host_view_mac_unittest.mm:966: Failure Value of: view_delegate.get().unhandledWheelEventReceived Actual: '' Expected: __objc_yes Which is: '?' (1) [3372:1287:0608/164121:1128775946716:FATAL:surface_manager.cc(43)] Check failed: namespace_client_map_.size() == 0u (1 vs. 0) """ Original issue's description: > Remove enable/disable wheel gestures setting. > > Since wheel gesture based scrolling has shipped and the code has been > removed from blink we can remove the runtime setting. > > BUG=598798 > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel > > Committed: https://crrev.com/3f5cea527647ebc8c505b1932d680854e162d82f > Cr-Commit-Position: refs/heads/master@{#398716} TBR=aelias@chromium.org,rbyers@chromium.org,creis@chromium.org,dtapuska@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=598798 Committed: https://crrev.com/463485dabfd8526d0d2a65ad9a42e0c28d5bffb8 Cr-Commit-Position: refs/heads/master@{#398746}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+921 lines, -58 lines) Patch
M cc/debug/debug_rect_history.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/proto/layer_tree_settings.proto View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +14 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 chunk +29 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_settings.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/layer_tree_settings.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M components/test_runner/event_sender.h View 2 chunks +5 lines, -0 lines 0 comments Download
M components/test_runner/event_sender.cc View 2 chunks +2 lines, -1 line 0 comments Download
M components/test_runner/web_test_proxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/test_runner/web_test_proxy.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl.cc View 2 chunks +4 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/input_router_impl_unittest.cc View 2 chunks +50 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/mouse_wheel_event_queue.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/input/mouse_wheel_event_queue.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc View 4 chunks +12 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/non_blocking_event_browsertest.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M content/browser/renderer_host/overscroll_controller.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/overscroll_controller.cc View 3 chunks +5 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 17 chunks +526 lines, -34 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 3 chunks +16 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_unittest.mm View 2 chunks +71 lines, -0 lines 0 comments Download
A content/common/input/input_event_utils.h View 1 chunk +17 lines, -0 lines 0 comments Download
A content/common/input/input_event_utils.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M content/content_common.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M content/public/common/content_switches.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M content/renderer/input/input_handler_manager.h View 2 chunks +4 lines, -2 lines 0 comments Download
M content/renderer/input/input_handler_manager.cc View 3 chunks +10 lines, -7 lines 0 comments Download
M content/renderer/input/input_handler_wrapper.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/input/input_handler_wrapper.cc View 2 chunks +4 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.cc View 2 chunks +3 lines, -1 line 0 comments Download
M content/shell/renderer/layout_test/layout_test_content_renderer_client.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/events/blink/input_handler_proxy.h View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/events/blink/input_handler_proxy.cc View 3 chunks +4 lines, -0 lines 0 comments Download
M ui/events/blink/input_handler_proxy_unittest.cc View 3 chunks +79 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
scheib
Created Revert of Remove enable/disable wheel gestures setting.
4 years, 6 months ago (2016-06-09 00:06:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2050033002/1
4 years, 6 months ago (2016-06-09 00:07:28 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 00:12:50 UTC) #5
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 00:15:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/463485dabfd8526d0d2a65ad9a42e0c28d5bffb8
Cr-Commit-Position: refs/heads/master@{#398746}

Powered by Google App Engine
This is Rietveld 408576698