Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Issue 2047093002: Remove enable/disable wheel gestures setting. (Closed)

Created:
4 years, 6 months ago by dtapuska
Modified:
4 years, 6 months ago
CC:
cc-bugs_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, dtapuska+chromiumwatch_chromium.org, jam, jochen+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-test-runner_chromium.org, nasko+codewatch_chromium.org, nona+watch_chromium.org, Peter Beverloo, piman+watch_chromium.org, shuchen+watch_chromium.org, James Su, tdresser+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@can_scroll_remove
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove enable/disable wheel gestures setting. Since wheel gesture based scrolling has shipped and the code has been removed from blink we can remove the runtime setting. BUG=598798 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/3f5cea527647ebc8c505b1932d680854e162d82f Committed: https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c Cr-Original-Commit-Position: refs/heads/master@{#398716} Cr-Commit-Position: refs/heads/master@{#398862}

Patch Set 1 #

Patch Set 2 : Fix build #

Patch Set 3 : Fix event_sender #

Patch Set 4 : Remove unused, uninitialized variable on mac causing occasional failure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -913 lines) Patch
M cc/debug/debug_rect_history.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/proto/layer_tree_settings.proto View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 2 3 1 chunk +0 lines, -14 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 2 3 1 chunk +6 lines, -29 lines 0 comments Download
M cc/trees/layer_tree_settings.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/layer_tree_settings.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M components/test_runner/event_sender.h View 1 2 2 chunks +0 lines, -5 lines 0 comments Download
M components/test_runner/event_sender.cc View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M components/test_runner/web_test_proxy.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M components/test_runner/web_test_proxy.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl.cc View 2 chunks +1 line, -4 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl_unittest.cc View 1 2 chunks +0 lines, -50 lines 0 comments Download
M content/browser/renderer_host/input/mouse_wheel_event_queue.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/input/mouse_wheel_event_queue.cc View 2 chunks +1 line, -3 lines 0 comments Download
M content/browser/renderer_host/input/mouse_wheel_event_queue_unittest.cc View 1 4 chunks +1 line, -12 lines 0 comments Download
M content/browser/renderer_host/input/non_blocking_event_browsertest.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M content/browser/renderer_host/overscroll_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/overscroll_controller.cc View 3 chunks +1 line, -5 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 1 16 chunks +21 lines, -513 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 2 3 2 chunks +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 2 3 3 chunks +0 lines, -18 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac_unittest.mm View 1 2 chunks +0 lines, -71 lines 0 comments Download
D content/common/input/input_event_utils.h View 1 chunk +0 lines, -17 lines 0 comments Download
D content/common/input/input_event_utils.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M content/content_common.gypi View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/common/content_switches.h View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M content/public/common/content_switches.cc View 1 2 3 2 chunks +0 lines, -6 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M content/renderer/input/input_handler_manager.h View 2 chunks +2 lines, -4 lines 0 comments Download
M content/renderer/input/input_handler_manager.cc View 3 chunks +7 lines, -10 lines 0 comments Download
M content/renderer/input/input_handler_wrapper.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/input/input_handler_wrapper.cc View 2 chunks +1 line, -4 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 2 chunks +1 line, -3 lines 0 comments Download
M content/shell/renderer/layout_test/layout_test_content_renderer_client.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/events/blink/input_handler_proxy.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ui/events/blink/input_handler_proxy.cc View 3 chunks +0 lines, -4 lines 0 comments Download
M ui/events/blink/input_handler_proxy_unittest.cc View 3 chunks +0 lines, -79 lines 0 comments Download

Messages

Total messages: 24 (12 generated)
dtapuska
aelias@ please take a look. This is a large change; but it purely a lot ...
4 years, 6 months ago (2016-06-08 18:14:44 UTC) #4
aelias_OOO_until_Jul13
lgtm!
4 years, 6 months ago (2016-06-08 18:55:41 UTC) #5
dtapuska
On 2016/06/08 18:55:41, aelias wrote: > lgtm! +rbyers for components/test_runner/* +creis for content/public/*, content/renderer/* (minus ...
4 years, 6 months ago (2016-06-08 19:07:44 UTC) #7
Rick Byers
On 2016/06/08 19:07:44, dtapuska wrote: > On 2016/06/08 18:55:41, aelias wrote: > > lgtm! > ...
4 years, 6 months ago (2016-06-08 19:55:14 UTC) #8
Charlie Reis
On 2016/06/08 19:55:14, Rick Byers wrote: > On 2016/06/08 19:07:44, dtapuska wrote: > > On ...
4 years, 6 months ago (2016-06-08 20:13:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2047093002/40001
4 years, 6 months ago (2016-06-08 21:23:01 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-08 22:59:34 UTC) #13
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/3f5cea527647ebc8c505b1932d680854e162d82f Cr-Commit-Position: refs/heads/master@{#398716}
4 years, 6 months ago (2016-06-08 23:01:14 UTC) #15
scheib
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2050033002/ by scheib@chromium.org. ...
4 years, 6 months ago (2016-06-09 00:06:58 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2047093002/60001
4 years, 6 months ago (2016-06-09 12:17:13 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 6 months ago (2016-06-09 13:42:10 UTC) #22
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 13:43:58 UTC) #24
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e7dd21de6085f5cdc0cfe4eaeeda56f27006761c
Cr-Commit-Position: refs/heads/master@{#398862}

Powered by Google App Engine
This is Rietveld 408576698