Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Issue 2049933003: Add effect node support in PaintArtifactCompositor for layer list mode [2/4] (Closed)

Created:
4 years, 6 months ago by trchen
Modified:
4 years, 6 months ago
Reviewers:
chrishtr, jbroman
CC:
jbroman, ajuma+watch_chromium.org, blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/src.git@pac_layer_list_step_1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add effect node support in PaintArtifactCompositor for layer list mode [2/4] This CL splits PaintArtifactCompositor::update into legacy mode and layer list mode. It expected that the code paths will diverge as we develop the layer list mode. BUG=609937 Committed: https://crrev.com/dc77f5550dd3e2f01663d5463fc761e49eab6d34 Cr-Commit-Position: refs/heads/master@{#400001}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -53 lines) Patch
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp View 1 3 chunks +57 lines, -52 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
trchen
Split out #2.
4 years, 6 months ago (2016-06-09 00:10:33 UTC) #3
jbroman
lgtm
4 years, 6 months ago (2016-06-15 12:28:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2049933003/1
4 years, 6 months ago (2016-06-15 12:28:21 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/builds/21393) ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 6 months ago (2016-06-15 12:29:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2049933003/20001
4 years, 6 months ago (2016-06-15 18:18:34 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-15 20:30:20 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-15 20:30:26 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 20:31:41 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dc77f5550dd3e2f01663d5463fc761e49eab6d34
Cr-Commit-Position: refs/heads/master@{#400001}

Powered by Google App Engine
This is Rietveld 408576698