runtime/bin/vmservice/client/lib/src/elements/isolate_profile.dart - Issue 204983008: Rework how ServiceObjects are created and cached in Observatory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/client/lib/src/elements/isolate_profile.dart

Issue 204983008: Rework how ServiceObjects are created and cached in Observatory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: edits Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/bin/vmservice/client/lib/src/elements/function_ref.dart ('k') | runtime/bin/vmservice/client/lib/src/elements/vm_view.html » ('j') | runtime/bin/vmservice/client/lib/src/service/object.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/client/lib/src/elements/isolate_profile.dart

diff --git a/runtime/bin/vmservice/client/lib/src/elements/isolate_profile.dart b/runtime/bin/vmservice/client/lib/src/elements/isolate_profile.dart

index 1e244df0b4527370901f4e04a254fd44b427f229..14391e1d0f0bc75cc0570184b5e67439869c6a88 100644

--- a/runtime/bin/vmservice/client/lib/src/elements/isolate_profile.dart

+++ b/runtime/bin/vmservice/client/lib/src/elements/isolate_profile.dart

@@ -77,7 +77,7 @@ class ProfileCallerTreeRow extends TableTreeRow {

var totalSamples = profile['samples'];

// When the row is created, fill out the columns.

if (parent == null) {

- var root = profile.isolate.codes.tagRoot();

+ var root = profile.isolate.tagRoot();

var totalAttributedCalls = root.callersCount(code);

var totalParentCalls = root.sumCallersCount();

columns.add(formatPercent(totalAttributedCalls, totalParentCalls));

@@ -188,7 +188,7 @@ class IsolateProfileElement extends ObservatoryElement {

void _buildCallersTree() {

assert(profile != null);

- var root = profile.isolate.codes.tagRoot();

+ var root = profile.isolate.tagRoot();

if (root == null) {

Logger.root.warning('No profile root tag.');

}