runtime/bin/vmservice/client/lib/src/elements/function_ref.dart - Issue 204983008: Rework how ServiceObjects are created and cached in Observatory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/client/lib/src/elements/function_ref.dart

Issue 204983008: Rework how ServiceObjects are created and cached in Observatory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: edits Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/bin/vmservice/client/lib/src/elements/eval_box.html ('k') | runtime/bin/vmservice/client/lib/src/elements/isolate_profile.dart » ('j') | runtime/bin/vmservice/client/lib/src/service/object.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/client/lib/src/elements/function_ref.dart

diff --git a/runtime/bin/vmservice/client/lib/src/elements/function_ref.dart b/runtime/bin/vmservice/client/lib/src/elements/function_ref.dart

index 0223bf1ba5ffffc07d42560acd9c201ba675f54b..c88333b0a89517dc9355d2f73c77bb520ba9f68d 100644

--- a/runtime/bin/vmservice/client/lib/src/elements/function_ref.dart

+++ b/runtime/bin/vmservice/client/lib/src/elements/function_ref.dart

@@ -5,6 +5,7 @@

library function_ref_element;

import 'package:polymer/polymer.dart';

+import 'package:observatory/service.dart';

import 'service_ref.dart';

@CustomTag('function-ref')

@@ -15,11 +16,12 @@ class FunctionRefElement extends ServiceRefElement {

super.refChanged(oldValue);

notifyPropertyChange(#hasParent, 0, 1);

notifyPropertyChange(#hasClass, 0, 1);

- hasParent = (ref != null && ref['parent'] != null);

- hasClass = (ref != null &&

- ref['class'] != null &&

- ref['class']['name'] != null &&

- ref['class']['name'] != '::');

+ ServiceMap refMap = ref;

+ hasParent = (refMap != null && refMap['parent'] != null);

+ hasClass = (refMap != null &&

+ refMap['class'] != null &&

+ refMap['class']['name'] != null &&

+ refMap['class']['name'] != '::');

}

@observable bool hasParent = false;