Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: runtime/bin/vmservice/client/lib/src/elements/function_ref.dart

Issue 204983008: Rework how ServiceObjects are created and cached in Observatory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: edits Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library function_ref_element; 5 library function_ref_element;
6 6
7 import 'package:polymer/polymer.dart'; 7 import 'package:polymer/polymer.dart';
8 import 'package:observatory/service.dart';
8 import 'service_ref.dart'; 9 import 'service_ref.dart';
9 10
10 @CustomTag('function-ref') 11 @CustomTag('function-ref')
11 class FunctionRefElement extends ServiceRefElement { 12 class FunctionRefElement extends ServiceRefElement {
12 @published bool qualified = true; 13 @published bool qualified = true;
13 14
14 void refChanged(oldValue) { 15 void refChanged(oldValue) {
15 super.refChanged(oldValue); 16 super.refChanged(oldValue);
16 notifyPropertyChange(#hasParent, 0, 1); 17 notifyPropertyChange(#hasParent, 0, 1);
17 notifyPropertyChange(#hasClass, 0, 1); 18 notifyPropertyChange(#hasClass, 0, 1);
18 hasParent = (ref != null && ref['parent'] != null); 19 ServiceMap refMap = ref;
19 hasClass = (ref != null && 20 hasParent = (refMap != null && refMap['parent'] != null);
20 ref['class'] != null && 21 hasClass = (refMap != null &&
21 ref['class']['name'] != null && 22 refMap['class'] != null &&
22 ref['class']['name'] != '::'); 23 refMap['class']['name'] != null &&
24 refMap['class']['name'] != '::');
23 } 25 }
24 26
25 @observable bool hasParent = false; 27 @observable bool hasParent = false;
26 @observable bool hasClass = false; 28 @observable bool hasClass = false;
27 29
28 FunctionRefElement.created() : super.created(); 30 FunctionRefElement.created() : super.created();
29 } 31 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698