Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(947)

Unified Diff: Source/core/fileapi/FileReaderLoader.cpp

Issue 204983007: Make ThreadableLoader class to use references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added asserts Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/inspector/InspectorResourceAgent.cpp » ('j') | Source/core/page/EventSource.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/fileapi/FileReaderLoader.cpp
diff --git a/Source/core/fileapi/FileReaderLoader.cpp b/Source/core/fileapi/FileReaderLoader.cpp
index 74e518bcb39cfff9711272e55bbfcaecf3aa1a4d..859b65a802582f462b586c78ba5133556c6ac11e 100644
--- a/Source/core/fileapi/FileReaderLoader.cpp
+++ b/Source/core/fileapi/FileReaderLoader.cpp
@@ -115,19 +115,21 @@ void FileReaderLoader::startInternal(ExecutionContext* executionContext, const S
options.initiator = FetchInitiatorTypeNames::internal;
if (m_client)
- m_loader = ThreadableLoader::create(executionContext, this, request, options);
+ m_loader = ThreadableLoader::create(*executionContext, this, request, options);
else
- ThreadableLoader::loadResourceSynchronously(executionContext, request, *this, options);
+ ThreadableLoader::loadResourceSynchronously(*executionContext, request, *this, options);
}
void FileReaderLoader::start(ExecutionContext* executionContext, PassRefPtr<BlobDataHandle> blobData)
{
+ ASSERT(executionContext);
Inactive 2014/03/31 17:43:26 Is it a lot of work to update the callers?
maheshkk 2014/03/31 20:46:49 I have changed the startInternal to use reference.
m_urlForReadingIsStream = false;
startInternal(executionContext, 0, blobData);
}
void FileReaderLoader::start(ExecutionContext* executionContext, const Stream& stream, unsigned readSize)
{
+ ASSERT(executionContext);
Inactive 2014/03/31 17:43:26 Ditto.
if (readSize > 0) {
m_hasRange = true;
m_rangeStart = 0;
« no previous file with comments | « no previous file | Source/core/inspector/InspectorResourceAgent.cpp » ('j') | Source/core/page/EventSource.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698