Make ThreadableLoader class to use references

Source/core/fileapi/FileReaderLoader.cpp

 /*
  * Copyright (C) 2010 Google Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 97 matching lines @@
     options.sniffContent = DoNotSniffContent;
     options.preflightPolicy = ConsiderPreflight;
     options.allowCredentials = AllowStoredCredentials;
     options.crossOriginRequestPolicy = DenyCrossOriginRequests;
     // FIXME: Is there a directive to which this load should be subject?
     options.contentSecurityPolicyEnforcement = DoNotEnforceContentSecurityPolicy;
     // Use special initiator to hide the request from the inspector.
     options.initiator = FetchInitiatorTypeNames::internal;
 
     if (m_client)
-        m_loader = ThreadableLoader::create(executionContext, this, request, options);
+        m_loader = ThreadableLoader::create(*executionContext, this, request, options);
     else
-        ThreadableLoader::loadResourceSynchronously(executionContext, request, *this, options);
+        ThreadableLoader::loadResourceSynchronously(*executionContext, request, *this, options);
 }
 
 void FileReaderLoader::start(ExecutionContext* executionContext, PassRefPtr<BlobDataHandle> blobData)
 {
+    ASSERT(executionContext);

[Inactive, 2014/03/31 17:43:26]

Is it a lot of work to update the callers?

[maheshkk, 2014/03/31 20:46:49]

I have changed the startInternal to use reference. Most of this class code now
uses reference for executeContext. 

There are 8 different callers to start() and will upload a different patch to
limit the number of files for this patch to review.  

     m_urlForReadingIsStream = false;
     startInternal(executionContext, 0, blobData);
 }
 
 void FileReaderLoader::start(ExecutionContext* executionContext, const Stream& stream, unsigned readSize)
 {
+    ASSERT(executionContext);

[Inactive, 2014/03/31 17:43:26]

Ditto.

     if (readSize > 0) {
         m_hasRange = true;
         m_rangeStart = 0;
         m_rangeEnd = readSize - 1; // End is inclusive so (0,0) is a 1-byte read.
     }
 
     m_urlForReadingIsStream = true;
     startInternal(executionContext, &stream, nullptr);
 }
 
@@ skipping 253 matching lines @@
     m_stringResult = builder.toString();
 }
 
 void FileReaderLoader::setEncoding(const String& encoding)
 {
     if (!encoding.isEmpty())
         m_encoding = WTF::TextEncoding(encoding);
 }
 
 } // namespace WebCore