Source/core/loader/WorkerThreadableLoader.h - Issue 204983007: Make ThreadableLoader class to use references

Unified Diff: Source/core/loader/WorkerThreadableLoader.h

Issue 204983007: Make ThreadableLoader class to use references (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/loader/ThreadableLoader.h ('K') | « Source/core/loader/ThreadableLoader.cpp ('k') | Source/core/loader/WorkerThreadableLoader.cpp » ('j') | Source/core/loader/WorkerThreadableLoader.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/loader/WorkerThreadableLoader.h

diff --git a/Source/core/loader/WorkerThreadableLoader.h b/Source/core/loader/WorkerThreadableLoader.h

index f1a747232f07cb5740cbc66d3bd1569fcd2e2a57..d1470e5a110a0665c0d63d2b373021bcc691877f 100644

--- a/Source/core/loader/WorkerThreadableLoader.h

+++ b/Source/core/loader/WorkerThreadableLoader.h

@@ -54,8 +54,8 @@ namespace WebCore {

class WorkerThreadableLoader FINAL : public RefCounted<WorkerThreadableLoader>, public ThreadableLoader {

WTF_MAKE_FAST_ALLOCATED;

public:

- static void loadResourceSynchronously(WorkerGlobalScope*, const ResourceRequest&, ThreadableLoaderClient&, const ThreadableLoaderOptions&);

- static PassRefPtr<WorkerThreadableLoader> create(WorkerGlobalScope* workerGlobalScope, PassRefPtr<ThreadableLoaderClientWrapper> clientWrapper, PassOwnPtr<ThreadableLoaderClient> clientBridge, const ResourceRequest& request, const ThreadableLoaderOptions& options)

+ static void loadResourceSynchronously(WorkerGlobalScope&, const ResourceRequest&, ThreadableLoaderClient&, const ThreadableLoaderOptions&);

+ static PassRefPtr<WorkerThreadableLoader> create(WorkerGlobalScope& workerGlobalScope, PassRefPtr<ThreadableLoaderClientWrapper> clientWrapper, PassOwnPtr<ThreadableLoaderClient> clientBridge, const ResourceRequest& request, const ThreadableLoaderOptions& options)

{

return adoptRef(new WorkerThreadableLoader(workerGlobalScope, clientWrapper, clientBridge, request, options));

}

@@ -132,9 +132,9 @@ namespace WebCore {

WorkerLoaderProxy& m_loaderProxy;

};

- WorkerThreadableLoader(WorkerGlobalScope*, PassRefPtr<ThreadableLoaderClientWrapper>, PassOwnPtr<ThreadableLoaderClient>, const ResourceRequest&, const ThreadableLoaderOptions&);

+ WorkerThreadableLoader(WorkerGlobalScope&, PassRefPtr<ThreadableLoaderClientWrapper>, PassOwnPtr<ThreadableLoaderClient>, const ResourceRequest&, const ThreadableLoaderOptions&);

- RefPtrWillBePersistent<WorkerGlobalScope> m_workerGlobalScope;

+ WorkerGlobalScope& m_workerGlobalScope;

Inactive 2014/03/22 15:09:54 This changes behavior. We no longer hold a strong

maheshkk 2014/03/24 18:17:48 Good point. I will leave this a RefPtr.

RefPtr<ThreadableLoaderClientWrapper> m_workerClientWrapper;

MainThreadBridge& m_bridge;

};