Chromium Code Reviews
DescriptionReland of Simplify import-w3c-tests: support exactly one argument. (patchset #1 id:1 of https://codereview.chromium.org/2048953002/ )
Reason for revert:
Making a reland CL to try to fix the unit test failure.
Original issue's description:
> Revert of Simplify import-w3c-tests: support exactly one argument. (patchset #7 id:120001 of https://codereview.chromium.org/1998413002/ )
>
> Reason for revert:
> This seems to have caused consecutive webkit python test failures. Probably there should be an easy fix but let me revert this for now.
>
> {
> "failures": [
> "webkitpy/w3c/test_importer_unittest/TestImporterTest/test_does_not_import_reftest"
> ],
> "valid": true
> }
>
> Original issue's description:
> > Simplify import-w3c-tests: support exactly one argument.
> >
> > Specifically, take the source repo path (top of repo) as the required argument, and don't support importing single subdirectories.
> >
> > Reason:
> >
> > 1. Using the current directory as the top of repo may be a bit confusing.
> >
> > 2. In the future, I believe we want some kind of auto-updater that updates everything at once and we won't need to support importing individual directories. At present, I believe the only thing that uses import-w3c-tests is update-w3c-deps which, which doesn't currently have an option for updating just one subdirectory.
> >
> > Committed: https://crrev.com/868f94e75ad4b86b2a8a6c15b694cde508af91ee
> > Cr-Commit-Position: refs/heads/master@{#398437}
>
> TBR=dpranke@chromium.org,ojan@chromium.org,qyearsley@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Committed: https://crrev.com/c34176442a2f64bfec4960a72a92d93865863ee9
> Cr-Commit-Position: refs/heads/master@{#398473}
TBR=dpranke@chromium.org,ojan@chromium.org,kinuko@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
Committed: https://crrev.com/6fe70e36410ade1c2aaf45eeb0eeaa81c8004717
Cr-Commit-Position: refs/heads/master@{#399782}
Patch Set 1 #Patch Set 2 : Fix the test #
Messages
Total messages: 13 (4 generated)
|
||||||||||||||||||||||||||||