Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2049803002: Reland of Simplify import-w3c-tests: support exactly one argument. (Closed)

Created:
4 years, 6 months ago by qyearsley
Modified:
4 years, 6 months ago
Reviewers:
kinuko, Dirk Pranke, ojan
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, dcampb, raikiri, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Simplify import-w3c-tests: support exactly one argument. (patchset #1 id:1 of https://codereview.chromium.org/2048953002/ ) Reason for revert: Making a reland CL to try to fix the unit test failure. Original issue's description: > Revert of Simplify import-w3c-tests: support exactly one argument. (patchset #7 id:120001 of https://codereview.chromium.org/1998413002/ ) > > Reason for revert: > This seems to have caused consecutive webkit python test failures. Probably there should be an easy fix but let me revert this for now. > > { > "failures": [ > "webkitpy/w3c/test_importer_unittest/TestImporterTest/test_does_not_import_reftest" > ], > "valid": true > } > > Original issue's description: > > Simplify import-w3c-tests: support exactly one argument. > > > > Specifically, take the source repo path (top of repo) as the required argument, and don't support importing single subdirectories. > > > > Reason: > > > > 1. Using the current directory as the top of repo may be a bit confusing. > > > > 2. In the future, I believe we want some kind of auto-updater that updates everything at once and we won't need to support importing individual directories. At present, I believe the only thing that uses import-w3c-tests is update-w3c-deps which, which doesn't currently have an option for updating just one subdirectory. > > > > Committed: https://crrev.com/868f94e75ad4b86b2a8a6c15b694cde508af91ee > > Cr-Commit-Position: refs/heads/master@{#398437} > > TBR=dpranke@chromium.org,ojan@chromium.org,qyearsley@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/c34176442a2f64bfec4960a72a92d93865863ee9 > Cr-Commit-Position: refs/heads/master@{#398473} TBR=dpranke@chromium.org,ojan@chromium.org,kinuko@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/6fe70e36410ade1c2aaf45eeb0eeaa81c8004717 Cr-Commit-Position: refs/heads/master@{#399782}

Patch Set 1 #

Patch Set 2 : Fix the test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -48 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py View 1 9 chunks +20 lines, -35 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py View 1 5 chunks +11 lines, -13 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
qyearsley
Created Reland of Simplify import-w3c-tests: support exactly one argument.
4 years, 6 months ago (2016-06-08 16:02:28 UTC) #2
Dirk Pranke
what's the change from the original patch, and do we know how this got past ...
4 years, 6 months ago (2016-06-08 16:06:21 UTC) #4
qyearsley
On 2016/06/08 at 16:06:21, dpranke wrote: > what's the change from the original patch, and ...
4 years, 6 months ago (2016-06-08 16:13:51 UTC) #5
qyearsley
On 2016/06/08 at 16:13:51, qyearsley wrote: > On 2016/06/08 at 16:06:21, dpranke wrote: > > ...
4 years, 6 months ago (2016-06-13 23:09:31 UTC) #6
Dirk Pranke
lgtm. If we get to a point where we need to import the repos independently ...
4 years, 6 months ago (2016-06-14 21:01:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2049803002/70001
4 years, 6 months ago (2016-06-14 21:10:52 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:70001)
4 years, 6 months ago (2016-06-14 21:40:46 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-14 21:40:52 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 21:42:15 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6fe70e36410ade1c2aaf45eeb0eeaa81c8004717
Cr-Commit-Position: refs/heads/master@{#399782}

Powered by Google App Engine
This is Rietveld 408576698