Fix test_importer.py to skip files named reftest.list and add test

Fix test_importer.py to skip files named reftest.list and add test

BUG=582838
Committed: https://crrev.com/310df7c013254c9f99d67f5e0b18560a832b1656
Cr-Commit-Position: refs/heads/master@{#398410}

[raikiri, 2016-06-07 21:01:59]

raikiri@google.com changed reviewers:
+ qyearsley@chromium.org

[qyearsley, 2016-06-07 21:12:57]

LGTM, although I suggest adding a comment before committing; sometimes it's
helpful to leave crbug links (http://crbug.com/584660 and
http://crbug.com/582838 in this case) in code to give historical context to
future readers.

https://codereview.chromium.org/2045013002/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py (right):

https://codereview.chromium.org/2045013002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py:234: continue  #
These files fail our presubmits.
For future readers of this code, I think it would be useful to have bug links
for context, e.g.:

# See http://crbug.com/584660 and http://crbug.com/582838.

[raikiri, 2016-06-07 21:36:16]

The CQ bit was checked by raikiri@google.com

[raikiri, 2016-06-07 21:36:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
qyearsley@chromium.org
Link to the patchset: https://codereview.chromium.org/2045013002/#ps20001
(title: "Added comment")

[commit-bot: I haz the power, 2016-06-07 21:37:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2045013002/20001

[Dirk Pranke, 2016-06-07 22:05:52]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-06-07 22:05:53]

https://codereview.chromium.org/2045013002/diff/20001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py (right):

https://codereview.chromium.org/2045013002/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py:235: # see 
http://crbug.com/584660 and
I probably wouldn't have added these comments; while I agree with qyearsley@
that sometimes it is helpful to have comments that link to bug numbers, in this
case it's fairly obvious that we're intentionally skipping files with these
names, and you can use version control to figure out the context for why this
was added. Otherwise every line in the file would eventually grow multiple bug
numbers :).

However, if you did want to explain *why* we're skipping them, it's better to do
so directly if you can do so in a fairly terse way, to keep the reader from
having to jump to the bug. 

For the OWNERS files, we should figure out if there is any advantage to
importing them in some other form that doesn't cause our presubmits to fail. 

For the reftest.list, we should figure out if we do want to support them at all,
and if we do, the reference to the bug is good but it should be of the form
'TODO(crbug.com/582838): Make reftest manifests work properly'.

[commit-bot: I haz the power, 2016-06-07 23:19:16]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-07 23:21:29]

Description was changed from

==========
Fix test_importer.py to skip files named reftest.list and add test

BUG=582838
==========

to

==========
Fix test_importer.py to skip files named reftest.list and add test

BUG=582838

Committed: https://crrev.com/310df7c013254c9f99d67f5e0b18560a832b1656
Cr-Commit-Position: refs/heads/master@{#398410}
==========

[commit-bot: I haz the power, 2016-06-07 23:21:30]

Patchset 2 (id:??) landed as
https://crrev.com/310df7c013254c9f99d67f5e0b18560a832b1656
Cr-Commit-Position: refs/heads/master@{#398410}