Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 2049723002: views/mus: Chaneg how Widget activation works in mus. (Closed)

Created:
4 years, 6 months ago by sadrul
Modified:
4 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

views/mus: Chaneg how Widget activation works in mus. Install an aura::client::FocusClient implementation on NativeWidgetMus's aura window-tree which focuses the mus::Window when the aura::Window is focused. This change allows running some tests in views/focus/focus_manager_unittest.cc under mus. BUG=577274 Committed: https://crrev.com/54c3afdc90bcdf7f12662e8dfcfd3ac3c4864332 Cr-Commit-Position: refs/heads/master@{#398610}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -4 lines) Patch
M ui/views/focus/focus_manager_unittest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/mus/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/mus/native_widget_mus.cc View 3 chunks +26 lines, -3 lines 0 comments Download
M ui/wm/core/focus_controller.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
sadrul
4 years, 6 months ago (2016-06-08 14:45:04 UTC) #2
sky
LGTM
4 years, 6 months ago (2016-06-08 17:31:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2049723002/1
4 years, 6 months ago (2016-06-08 17:33:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 17:37:21 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 17:38:20 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/54c3afdc90bcdf7f12662e8dfcfd3ac3c4864332
Cr-Commit-Position: refs/heads/master@{#398610}

Powered by Google App Engine
This is Rietveld 408576698