chrome/browser/ui/webui/signin/inline_login_handler.cc - Issue 2049683002: Wire up the Chrome Sign In modal dialog from the password bubble promo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/signin/inline_login_handler.cc

Issue 2049683002: Wire up the Chrome Sign In modal dialog from the password bubble promo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix histograms Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_ui_controller.cc ('k') | components/signin/core/browser/signin_metrics.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/signin/inline_login_handler.cc

diff --git a/chrome/browser/ui/webui/signin/inline_login_handler.cc b/chrome/browser/ui/webui/signin/inline_login_handler.cc

index 8fea1e3e1922aa7311aa1c91ef2ebd00f127af33..0160dcc3856984c99d75431ddee27700a898a621 100644

--- a/chrome/browser/ui/webui/signin/inline_login_handler.cc

+++ b/chrome/browser/ui/webui/signin/inline_login_handler.cc

@@ -165,6 +165,10 @@ void InlineLoginHandler::RecordSigninUserActionForAccessPoint(

content::RecordAction(

base::UserMetricsAction("Signin_Signin_FromRecentTabs"));

break;

+ case signin_metrics::AccessPoint::ACCESS_POINT_PASSWORD_BUBBLE:

gogerald1 2016/06/08 18:02:56 nit, better to keep the same order, move it below

vasilii 2016/06/09 08:37:03 Done.

+ content::RecordAction(

+ base::UserMetricsAction("Signin_Signin_FromPasswordBubble"));

+ break;

case signin_metrics::AccessPoint::ACCESS_POINT_UNKNOWN:

content::RecordAction(

base::UserMetricsAction("Signin_Signin_FromUnknownAccessPoint"));

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_ui_controller.cc ('k') | components/signin/core/browser/signin_metrics.h » ('j') | no next file with comments »