Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Side by Side Diff: chrome/browser/ui/webui/signin/inline_login_handler.cc

Issue 2049683002: Wire up the Chrome Sign In modal dialog from the password bubble promo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix histograms Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/signin/inline_login_handler.h" 5 #include "chrome/browser/ui/webui/signin/inline_login_handler.h"
6 6
7 #include <limits.h> 7 #include <limits.h>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/strings/string_number_conversions.h" 10 #include "base/strings/string_number_conversions.h"
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 base::UserMetricsAction("Signin_Signin_FromContentArea")); 158 base::UserMetricsAction("Signin_Signin_FromContentArea"));
159 break; 159 break;
160 case signin_metrics::AccessPoint::ACCESS_POINT_SIGNIN_PROMO: 160 case signin_metrics::AccessPoint::ACCESS_POINT_SIGNIN_PROMO:
161 content::RecordAction( 161 content::RecordAction(
162 base::UserMetricsAction("Signin_Signin_FromSigninPromo")); 162 base::UserMetricsAction("Signin_Signin_FromSigninPromo"));
163 break; 163 break;
164 case signin_metrics::AccessPoint::ACCESS_POINT_RECENT_TABS: 164 case signin_metrics::AccessPoint::ACCESS_POINT_RECENT_TABS:
165 content::RecordAction( 165 content::RecordAction(
166 base::UserMetricsAction("Signin_Signin_FromRecentTabs")); 166 base::UserMetricsAction("Signin_Signin_FromRecentTabs"));
167 break; 167 break;
168 case signin_metrics::AccessPoint::ACCESS_POINT_PASSWORD_BUBBLE:
gogerald1 2016/06/08 18:02:56 nit, better to keep the same order, move it below
vasilii 2016/06/09 08:37:03 Done.
169 content::RecordAction(
170 base::UserMetricsAction("Signin_Signin_FromPasswordBubble"));
171 break;
168 case signin_metrics::AccessPoint::ACCESS_POINT_UNKNOWN: 172 case signin_metrics::AccessPoint::ACCESS_POINT_UNKNOWN:
169 content::RecordAction( 173 content::RecordAction(
170 base::UserMetricsAction("Signin_Signin_FromUnknownAccessPoint")); 174 base::UserMetricsAction("Signin_Signin_FromUnknownAccessPoint"));
171 break; 175 break;
172 case signin_metrics::AccessPoint::ACCESS_POINT_MAX: 176 case signin_metrics::AccessPoint::ACCESS_POINT_MAX:
173 NOTREACHED(); 177 NOTREACHED();
174 break; 178 break;
175 } 179 }
176 } 180 }
177 181
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
280 284
281 browser->signin_view_controller()->delegate()->PerformNavigation(); 285 browser->signin_view_controller()->delegate()->PerformNavigation();
282 } 286 }
283 287
284 void InlineLoginHandler::HandleDialogClose(const base::ListValue* args) { 288 void InlineLoginHandler::HandleDialogClose(const base::ListValue* args) {
285 Browser* browser = GetDesktopBrowser(web_ui()); 289 Browser* browser = GetDesktopBrowser(web_ui());
286 DCHECK(browser); 290 DCHECK(browser);
287 291
288 browser->CloseModalSigninWindow(); 292 browser->CloseModalSigninWindow();
289 } 293 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_ui_controller.cc ('k') | components/signin/core/browser/signin_metrics.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698