Run more tests with --ignition-generators.

Run more tests with --ignition-generators.

Also, make %GeneratorGetSourcePosition fail if called on a suspended Ignition generator
(rather than return nonsense).  This functionality is currently not implemented.

BUG=v8:4907
Committed: https://crrev.com/ea139c5b4ae4d77a17bf57d2330f923f77ebd7a7
Cr-Commit-Position: refs/heads/master@{#36822}

[neis, 2016-06-08 09:17:42]

The CQ bit was checked by neis@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-08 09:17:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2049663002/1

[neis, 2016-06-08 09:18:15]

Description was changed from

==========
Run more tests with --ignition-generators.

Also, make %GeneratorGetSourcePosition fail if called on an Ignition generator
(rather than return nonsense).  This functionality is currently not implemented.

BUG=
==========

to

==========
Run more tests with --ignition-generators.

Also, make %GeneratorGetSourcePosition fail if called on a suspended Ignition
generator
(rather than return nonsense).  This functionality is currently not implemented.

BUG=
==========

[neis, 2016-06-08 09:20:06]

Description was changed from

==========
Run more tests with --ignition-generators.

Also, make %GeneratorGetSourcePosition fail if called on a suspended Ignition
generator
(rather than return nonsense).  This functionality is currently not implemented.

BUG=
==========

to

==========
Run more tests with --ignition-generators.

Also, make %GeneratorGetSourcePosition fail if called on a suspended Ignition
generator
(rather than return nonsense).  This functionality is currently not implemented.

BUG=v8:4907
==========

[neis, 2016-06-08 09:31:33]

neis@chromium.org changed reviewers:
+ yangguo@chromium.org

[neis, 2016-06-08 09:31:34]

PTAL.

There are two remaining debug tests that fail when run with
--ignition-generators:

mjsunit/es6/generators-mirror: triggers a call of %GetGeneratorSourcePosition on
a suspended generator, so the failure is expected.

mjsunit/es6/debug-stepin-generators: not yet sure why this fails.

[commit-bot: I haz the power, 2016-06-08 09:43:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-08 09:43:11]

Dry run: This issue passed the CQ dry run.

[Yang, 2016-06-08 11:36:56]

https://codereview.chromium.org/2049663002/diff/1/src/debug/debug.cc
File src/debug/debug.cc (right):

https://codereview.chromium.org/2049663002/diff/1/src/debug/debug.cc#newcode1336
src/debug/debug.cc:1336: DCHECK(shared->is_compiled());
We have this DCHECK above. Do we really need this?

https://codereview.chromium.org/2049663002/diff/1/test/mjsunit/debug-generato...
File test/mjsunit/debug-generator-break.js (right):

https://codereview.chromium.org/2049663002/diff/1/test/mjsunit/debug-generato...
test/mjsunit/debug-generator-break.js:5: // Flags: --expose-debug-as debug
--ignition-generators
Does this mean we are losing coverage for old-style generators?

[neis, 2016-06-08 11:51:14]

On 2016/06/08 11:36:56, Yang wrote:
> https://codereview.chromium.org/2049663002/diff/1/src/debug/debug.cc
> File src/debug/debug.cc (right):
> 
>
https://codereview.chromium.org/2049663002/diff/1/src/debug/debug.cc#newcode1336
> src/debug/debug.cc:1336: DCHECK(shared->is_compiled());
> We have this DCHECK above. Do we really need this?

At some point Michi and I were wondering if the GC invocation maybe caused the
code to be flushed.
 
>
https://codereview.chromium.org/2049663002/diff/1/test/mjsunit/debug-generato...
> File test/mjsunit/debug-generator-break.js (right):
> 
>
https://codereview.chromium.org/2049663002/diff/1/test/mjsunit/debug-generato...
> test/mjsunit/debug-generator-break.js:5: // Flags: --expose-debug-as debug
> --ignition-generators
> Does this mean we are losing coverage for old-style generators?

No, --ignition-generators only becomes meaningful when used with --ignition
(i.e. in some variants).

[Yang, 2016-06-08 11:55:14]

On 2016/06/08 11:51:14, neis wrote:
> On 2016/06/08 11:36:56, Yang wrote:
> > https://codereview.chromium.org/2049663002/diff/1/src/debug/debug.cc
> > File src/debug/debug.cc (right):
> > 
> >
>
https://codereview.chromium.org/2049663002/diff/1/src/debug/debug.cc#newcode1336
> > src/debug/debug.cc:1336: DCHECK(shared->is_compiled());
> > We have this DCHECK above. Do we really need this?
> 
> At some point Michi and I were wondering if the GC invocation maybe caused the
> code to be flushed.
>  
> >
>
https://codereview.chromium.org/2049663002/diff/1/test/mjsunit/debug-generato...
> > File test/mjsunit/debug-generator-break.js (right):
> > 
> >
>
https://codereview.chromium.org/2049663002/diff/1/test/mjsunit/debug-generato...
> > test/mjsunit/debug-generator-break.js:5: // Flags: --expose-debug-as debug
> > --ignition-generators
> > Does this mean we are losing coverage for old-style generators?
> 
> No, --ignition-generators only becomes meaningful when used with --ignition
> (i.e. in some variants).

lgtm.

[neis, 2016-06-08 11:55:39]

The CQ bit was checked by neis@chromium.org

[commit-bot: I haz the power, 2016-06-08 11:55:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2049663002/1

[commit-bot: I haz the power, 2016-06-08 11:58:09]

Description was changed from

==========
Run more tests with --ignition-generators.

Also, make %GeneratorGetSourcePosition fail if called on a suspended Ignition
generator
(rather than return nonsense).  This functionality is currently not implemented.

BUG=v8:4907
==========

to

==========
Run more tests with --ignition-generators.

Also, make %GeneratorGetSourcePosition fail if called on a suspended Ignition
generator
(rather than return nonsense).  This functionality is currently not implemented.

BUG=v8:4907
==========

[commit-bot: I haz the power, 2016-06-08 11:58:10]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-08 12:00:00]

Description was changed from

==========
Run more tests with --ignition-generators.

Also, make %GeneratorGetSourcePosition fail if called on a suspended Ignition
generator
(rather than return nonsense).  This functionality is currently not implemented.

BUG=v8:4907
==========

to

==========
Run more tests with --ignition-generators.

Also, make %GeneratorGetSourcePosition fail if called on a suspended Ignition
generator
(rather than return nonsense).  This functionality is currently not implemented.

BUG=v8:4907

Committed: https://crrev.com/ea139c5b4ae4d77a17bf57d2330f923f77ebd7a7
Cr-Commit-Position: refs/heads/master@{#36822}
==========

[commit-bot: I haz the power, 2016-06-08 12:00:01]

Patchset 1 (id:??) landed as
https://crrev.com/ea139c5b4ae4d77a17bf57d2330f923f77ebd7a7
Cr-Commit-Position: refs/heads/master@{#36822}