src/debug/debug.cc - Issue 2049663002: Run more tests with --ignition-generators.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/debug/debug.cc

Issue 2049663002: Run more tests with --ignition-generators. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/debug/debug.cc

diff --git a/src/debug/debug.cc b/src/debug/debug.cc

index 79bbad4e5d6fc5833abe225cf2dbc9e39da74577..214d72e7c27abd486a994b5f33b7f7149d29071a 100644

--- a/src/debug/debug.cc

+++ b/src/debug/debug.cc

@@ -1333,6 +1333,7 @@ bool Debug::PrepareFunctionForBreakPoints(Handle<SharedFunctionInfo> shared) {

isolate_->heap()->CollectAllGarbage(Heap::kMakeHeapIterableMask,

"prepare for break points");

+ DCHECK(shared->is_compiled());

Yang 2016/06/08 11:36:55 We have this DCHECK above. Do we really need this?

bool is_interpreted = shared->HasBytecodeArray();

{

« no previous file with comments | « no previous file | src/runtime/runtime-generator.cc » ('j') | test/mjsunit/debug-generator-break.js » ('J')