Implement ProtoDatabase::GetEntry

Implement ProtoDatabase::GetEntry

Before this CL, ProtoDatabase only exposed a LoadEntries method that loads the whole database at once. This CL adds a GetEntry method that loads a single entry.

BUG=605870
Committed: https://crrev.com/4fe73e380cb4d0a822f0fd621350d416a8dbfd10
Cr-Commit-Position: refs/heads/master@{#400160}

[Marc Treib, 2016-06-14 14:14:56]

Description was changed from

==========
Implement ProtoDatabase::Get

BUG=
==========

to

==========
Implement ProtoDatabase::GetEntry

Before this CL, ProtoDatabase only exposed a LoadEntries method that loads the
whole database at once. This CL adds a GetEntry method that loads a single
entry.

BUG=605870
==========

[Marc Treib, 2016-06-14 14:16:06]

treib@chromium.org changed reviewers:
+ mathp@chromium.org

[Marc Treib, 2016-06-14 14:16:06]

PTAL!

The new method isn't used yet, but the CL that needs it will (hopefully) follow
soon: https://codereview.chromium.org/2047713002

[Mathieu, 2016-06-15 00:52:45]

On 2016/06/14 at 14:16:06, treib wrote:
> PTAL!
> 
> The new method isn't used yet, but the CL that needs it will (hopefully)
follow soon: https://codereview.chromium.org/2047713002

Hi Marc, 

Looks great, do you think you could update proto_database_impl_unittest.cc?

Thanks

[Marc Treib, 2016-06-15 12:35:44]

On 2016/06/15 00:52:45, Mathieu Perreault wrote:
> On 2016/06/14 at 14:16:06, treib wrote:
> > PTAL!
> > 
> > The new method isn't used yet, but the CL that needs it will (hopefully)
> follow soon: https://codereview.chromium.org/2047713002
> 
> Hi Marc, 
> 
> Looks great, do you think you could update proto_database_impl_unittest.cc?
> 
> Thanks

D'oh, not sure how I could have missed that. Tests added.

I also made one other change (in separate patch set 4): The Get method now
differentiates between "error" and "not found". (The existing methods like Load
and Save don't have that distinction - they can only succeed or error.)

[Marc Treib, 2016-06-15 12:35:59]

https://codereview.chromium.org/2049573003/diff/20001/components/leveldb_prot...
File components/leveldb_proto/proto_database_impl_unittest.cc (left):

https://codereview.chromium.org/2049573003/diff/20001/components/leveldb_prot...
components/leveldb_proto/proto_database_impl_unittest.cc:49: ON_CALL(*this,
Load(_)).WillByDefault(Return(true));
All these default actions weren't actually needed - all tests still pass,
without any "uninteresting mock function call" warnings. And IMO these have the
potential of hiding problems, so I think it's best to just remove them. WDYT?

[Marc Treib, 2016-06-15 12:40:11]

The CQ bit was checked by treib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-15 12:40:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2049573003/60001

[commit-bot: I haz the power, 2016-06-15 15:13:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-15 15:13:44]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mathieu, 2016-06-16 14:05:07]

lgtm, thanks for the delay

[Marc Treib, 2016-06-16 14:13:14]

The CQ bit was checked by treib@chromium.org

[commit-bot: I haz the power, 2016-06-16 14:13:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2049573003/60001

[commit-bot: I haz the power, 2016-06-16 15:36:29]

Description was changed from

==========
Implement ProtoDatabase::GetEntry

Before this CL, ProtoDatabase only exposed a LoadEntries method that loads the
whole database at once. This CL adds a GetEntry method that loads a single
entry.

BUG=605870
==========

to

==========
Implement ProtoDatabase::GetEntry

Before this CL, ProtoDatabase only exposed a LoadEntries method that loads the
whole database at once. This CL adds a GetEntry method that loads a single
entry.

BUG=605870
==========

[commit-bot: I haz the power, 2016-06-16 15:36:32]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-06-16 15:36:51]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-16 15:38:22]

Description was changed from

==========
Implement ProtoDatabase::GetEntry

Before this CL, ProtoDatabase only exposed a LoadEntries method that loads the
whole database at once. This CL adds a GetEntry method that loads a single
entry.

BUG=605870
==========

to

==========
Implement ProtoDatabase::GetEntry

Before this CL, ProtoDatabase only exposed a LoadEntries method that loads the
whole database at once. This CL adds a GetEntry method that loads a single
entry.

BUG=605870

Committed: https://crrev.com/4fe73e380cb4d0a822f0fd621350d416a8dbfd10
Cr-Commit-Position: refs/heads/master@{#400160}
==========

[commit-bot: I haz the power, 2016-06-16 15:38:23]

Patchset 4 (id:??) landed as
https://crrev.com/4fe73e380cb4d0a822f0fd621350d416a8dbfd10
Cr-Commit-Position: refs/heads/master@{#400160}