Remove the default wheel event handler from blink.

Remove the default wheel event handler from blink.

Wheel gesture scrolls are used solely now. Remove the
defaultWheelEventHandler code as it is unused.

Also remove the WebSetting for wheel gesture support.

BUG=598798
Committed: https://crrev.com/256b95a4dce8f1e57e69ff0032ee16d4c76e580b
Cr-Commit-Position: refs/heads/master@{#398618}

[dtapuska, 2016-06-07 21:00:25]

Description was changed from

==========
Remove the default wheel event handler from blink.

Wheel gesture scrolls are used solely now. Remove the
defaultWheelEventHandler code as it is unused.

BUG=598798
==========

to

==========
Remove the default wheel event handler from blink.

Wheel gesture scrolls are used solely now. Remove the
defaultWheelEventHandler code as it is unused.

Also remove the WebSetting for wheel gesture support.


BUG=598798
==========

[dtapuska, 2016-06-07 21:01:42]

dtapuska@chromium.org changed reviewers:
+ bokan@chromium.org

[bokan, 2016-06-08 15:26:51]

Good riddance! lgtm!

https://codereview.chromium.org/2049493002/diff/20001/content/renderer/render...
File content/renderer/render_view_impl.cc (left):

https://codereview.chromium.org/2049493002/diff/20001/content/renderer/render...
content/renderer/render_view_impl.cc:1161:
settings->setWheelGesturesEnabled(UseGestureBasedWheelScrolling());
Should we remove UseGestureBasedWheelScrolling() as well or will you do that in
a separate patch?

https://codereview.chromium.org/2049493002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/input/EventHandler.cpp (right):

https://codereview.chromium.org/2049493002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/input/EventHandler.cpp:1631: return
WebInputEventResult::NotHandled;
We can just `return result` here instead.

[dtapuska, 2016-06-08 15:36:04]

https://codereview.chromium.org/2049493002/diff/20001/content/renderer/render...
File content/renderer/render_view_impl.cc (left):

https://codereview.chromium.org/2049493002/diff/20001/content/renderer/render...
content/renderer/render_view_impl.cc:1161:
settings->setWheelGesturesEnabled(UseGestureBasedWheelScrolling());
On 2016/06/08 15:26:51, bokan wrote:
> Should we remove UseGestureBasedWheelScrolling() as well or will you do that
in
> a separate patch?

separate patch.

https://codereview.chromium.org/2049493002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/input/EventHandler.cpp (right):

https://codereview.chromium.org/2049493002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/input/EventHandler.cpp:1631: return
WebInputEventResult::NotHandled;
On 2016/06/08 15:26:51, bokan wrote:
> We can just `return result` here instead.

Done.

https://codereview.chromium.org/2049493002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/input/EventHandler.cpp:1631: return
WebInputEventResult::NotHandled;
On 2016/06/08 15:26:51, bokan wrote:
> We can just `return result` here instead.

Done.

[dtapuska, 2016-06-08 15:38:02]

dtapuska@chromium.org changed reviewers:
+ esprehn@chromium.org

[dtapuska, 2016-06-08 15:38:30]

On 2016/06/08 15:36:04, dtapuska wrote:
>
https://codereview.chromium.org/2049493002/diff/20001/content/renderer/render...
> File content/renderer/render_view_impl.cc (left):
> 
>
https://codereview.chromium.org/2049493002/diff/20001/content/renderer/render...
> content/renderer/render_view_impl.cc:1161:
> settings->setWheelGesturesEnabled(UseGestureBasedWheelScrolling());
> On 2016/06/08 15:26:51, bokan wrote:
> > Should we remove UseGestureBasedWheelScrolling() as well or will you do that
> in
> > a separate patch?
> 
> separate patch.
> 
>
https://codereview.chromium.org/2049493002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/input/EventHandler.cpp (right):
> 
>
https://codereview.chromium.org/2049493002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/input/EventHandler.cpp:1631: return
> WebInputEventResult::NotHandled;
> On 2016/06/08 15:26:51, bokan wrote:
> > We can just `return result` here instead.
> 
> Done.
> 
>
https://codereview.chromium.org/2049493002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/input/EventHandler.cpp:1631: return
> WebInputEventResult::NotHandled;
> On 2016/06/08 15:26:51, bokan wrote:
> > We can just `return result` here instead.
> 
> Done.

+esprehn for public/web & content/renderer/

[esprehn, 2016-06-08 16:04:30]

Are we confident we can fix the regressions like the scrollbar one I just filed
and not need to flip this off again? :)

lgtm

[dtapuska, 2016-06-08 17:44:57]

The CQ bit was checked by dtapuska@chromium.org

[dtapuska, 2016-06-08 17:44:58]

The patchset sent to the CQ was uploaded after l-g-t-m from bokan@chromium.org
Link to the patchset: https://codereview.chromium.org/2049493002/#ps40001
(title: "Remove two tests, fix nit")

[commit-bot: I haz the power, 2016-06-08 17:45:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2049493002/40001

[commit-bot: I haz the power, 2016-06-08 18:10:12]

Description was changed from

==========
Remove the default wheel event handler from blink.

Wheel gesture scrolls are used solely now. Remove the
defaultWheelEventHandler code as it is unused.

Also remove the WebSetting for wheel gesture support.


BUG=598798
==========

to

==========
Remove the default wheel event handler from blink.

Wheel gesture scrolls are used solely now. Remove the
defaultWheelEventHandler code as it is unused.

Also remove the WebSetting for wheel gesture support.


BUG=598798
==========

[commit-bot: I haz the power, 2016-06-08 18:10:13]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-08 18:12:52]

Description was changed from

==========
Remove the default wheel event handler from blink.

Wheel gesture scrolls are used solely now. Remove the
defaultWheelEventHandler code as it is unused.

Also remove the WebSetting for wheel gesture support.


BUG=598798
==========

to

==========
Remove the default wheel event handler from blink.

Wheel gesture scrolls are used solely now. Remove the
defaultWheelEventHandler code as it is unused.

Also remove the WebSetting for wheel gesture support.

BUG=598798

Committed: https://crrev.com/256b95a4dce8f1e57e69ff0032ee16d4c76e580b
Cr-Commit-Position: refs/heads/master@{#398618}
==========

[commit-bot: I haz the power, 2016-06-08 18:12:54]

Patchset 3 (id:??) landed as
https://crrev.com/256b95a4dce8f1e57e69ff0032ee16d4c76e580b
Cr-Commit-Position: refs/heads/master@{#398618}