Issue 2049293002: Avoid double deleting from |MediaStreamDispatcher::label_stream_map_|. MediaStreamDispatcher::OnDev…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2049293002: Avoid double deleting from |MediaStreamDispatcher::label_stream_map_|. MediaStreamDispatcher::OnDev… (Closed)

Created:
4 years, 6 months ago by miu

Modified:
4 years, 6 months ago

Reviewers:
xjz

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2743

Target Ref:
refs/pending/branch-heads/2743

Project:
chromium

Visibility:
Public.

Avoid double deleting from |MediaStreamDispatcher::label_stream_map_|. MediaStreamDispatcher::OnDeviceStopped() may delete the same element twice from |label_stream_map_| and causes the crash. BUG=616884 TBR=xjz@chromium.org Review-Url: https://codereview.chromium.org/2035993002 Cr-Commit-Position: refs/heads/master@{#398075} (cherry picked from commit c4ef1a4e478937783c303b8a712e9fef0457ac60) Committed: https://chromium.googlesource.com/chromium/src/+/a279df07994a42c625120bbf20d7f3d4c67f4197

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	content/renderer/media/media_stream_dispatcher.cc	View		1 chunk	+9 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

miu

4 years, 6 months ago (2016-06-08 21:34:05 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a279df07994a42c625120bbf20d7f3d4c67f4197.