Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2035993002: Avoid double deleting from |MediaStreamDispatcher::label_stream_map_|. (Closed)

Created:
4 years, 6 months ago by xjz
Modified:
4 years, 6 months ago
Reviewers:
miu
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, mkwst+moarreviews-renderer_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid double deleting from |MediaStreamDispatcher::label_stream_map_|. MediaStreamDispatcher::OnDeviceStopped() may delete the same element twice from |label_stream_map_| and causes the crash. BUG=616884 Committed: https://crrev.com/c4ef1a4e478937783c303b8a712e9fef0457ac60 Cr-Commit-Position: refs/heads/master@{#398075}

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : Addressed comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M content/renderer/media/media_stream_dispatcher.cc View 1 2 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
xjz
PTAL
4 years, 6 months ago (2016-06-02 22:23:13 UTC) #2
xjz
PTAL PS#2. Added comment and fixed the bug that |stream| might be already invalidated.
4 years, 6 months ago (2016-06-03 19:21:58 UTC) #3
miu
lgtm % nit: https://codereview.chromium.org/2035993002/diff/20001/content/renderer/media/media_stream_dispatcher.cc File content/renderer/media/media_stream_dispatcher.cc (right): https://codereview.chromium.org/2035993002/diff/20001/content/renderer/media/media_stream_dispatcher.cc#newcode359 content/renderer/media/media_stream_dispatcher.cc:359: // be done to resolve this ...
4 years, 6 months ago (2016-06-04 04:30:01 UTC) #4
xjz
Addressed comments. https://codereview.chromium.org/2035993002/diff/20001/content/renderer/media/media_stream_dispatcher.cc File content/renderer/media/media_stream_dispatcher.cc (right): https://codereview.chromium.org/2035993002/diff/20001/content/renderer/media/media_stream_dispatcher.cc#newcode359 content/renderer/media/media_stream_dispatcher.cc:359: // be done to resolve this re-entering ...
4 years, 6 months ago (2016-06-06 17:09:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2035993002/40001
4 years, 6 months ago (2016-06-06 17:10:24 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-06 18:34:39 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 18:37:22 UTC) #11
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/c4ef1a4e478937783c303b8a712e9fef0457ac60
Cr-Commit-Position: refs/heads/master@{#398075}

Powered by Google App Engine
This is Rietveld 408576698