Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(957)

Issue 2049163003: Fixes ASan crash for an embedded Blink-in-JS component. (Closed)

Created:
4 years, 6 months ago by ikilpatrick
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Fixes ASan crash for an embedded Blink-in-JS component. In the test case (in this patch) it appears the Blink-in-JS component tries to run JS during document creation. However there is a ScriptForbidden scope which throws a "Uncaught Error: Script execution is forbidden." (probably because it is being created in this weird place?) This patch re-adds the simple check that was removed in https://codereview.chromium.org/1885833002 which checked if the toDOMWindow(isolate->GetEnteredContext()) was null. (now the check is just isolate->GetEnteredContext()->IsEmpty()). BUG=617104 Review-Url: https://codereview.chromium.org/2039333002 Cr-Commit-Position: refs/heads/master@{#398310} (cherry picked from commit 2deeee5b5604eb997fa053a1b6ab4268c662596f) Committed: https://chromium.googlesource.com/chromium/src/+/0dccfd08b8278a4ac6e3c3ad0698a4e45f3efc0d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/bindings/blink-in-js-asan-crash.html View 1 chunk +31 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/bindings/blink-in-js-asan-crash-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
ikilpatrick
4 years, 6 months ago (2016-06-08 19:33:52 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0dccfd08b8278a4ac6e3c3ad0698a4e45f3efc0d.

Powered by Google App Engine
This is Rietveld 408576698