Fixes ASan crash for an embedded Blink-in-JS component.

Fixes ASan crash for an embedded Blink-in-JS component.

In the test case (in this patch) it appears the Blink-in-JS component tries to run JS during document creation.
However there is a ScriptForbidden scope which throws a "Uncaught Error: Script execution is forbidden." (probably because it is being created in this weird place?)

This patch re-adds the simple check that was removed in https://codereview.chromium.org/1885833002 which checked if the toDOMWindow(isolate->GetEnteredContext()) was null.
(now the check is just isolate->GetEnteredContext()->IsEmpty()).

BUG=617104
Committed: https://crrev.com/2deeee5b5604eb997fa053a1b6ab4268c662596f
Cr-Commit-Position: refs/heads/master@{#398310}

[ikilpatrick, 2016-06-06 19:32:11]

Description was changed from

==========
Fixes ASan crash for an embedded Blink-in-JS component.

In the test case (in this patch) it appears the Blink-in-JS component tries
to...

BUG=617104
==========

to

==========
Fixes ASan crash for an embedded Blink-in-JS component.

In the test case (in this patch) it appears the Blink-in-JS component tries
to...

BUG=617104
==========

[ikilpatrick, 2016-06-06 19:44:09]

Description was changed from

==========
Fixes ASan crash for an embedded Blink-in-JS component.

In the test case (in this patch) it appears the Blink-in-JS component tries
to...

BUG=617104
==========

to

==========
Fixes ASan crash for an embedded Blink-in-JS component.

In the test case (in this patch) it appears the Blink-in-JS component tries to
run JS during document creation.
However there is a ScriptForbidden scope which throws a "Uncaught Error: Script
execution is forbidden." (probably because it is being created in this weird
place?)

This patch re-adds the simple check that was removed in
https://codereview.chromium.org/1885833002 which checked if the
toDOMWindow(isolate->GetEnteredContext()) was null.
(now the check is just isolate->GetEnteredContext()->IsEmpty()).

BUG=617104
==========

[ikilpatrick, 2016-06-06 19:44:09]

ikilpatrick@chromium.org changed reviewers:
+ domenic@chromium.org, haraken@chromium.org, yhirano@chromium.org

[yhirano, 2016-06-06 22:56:42]

lgtm

[haraken, 2016-06-06 23:21:14]

LGTM

I guess that isolate->GetCurrentContext()->IsEmpty() would be a better check
though (because ScriptState::current uses the current context, not the entered
context).

[ikilpatrick, 2016-06-07 00:15:24]

On 2016/06/06 23:21:14, haraken wrote:
> LGTM
> 
> I guess that isolate->GetCurrentContext()->IsEmpty() would be a better check
> though (because ScriptState::current uses the current context, not the entered
> context).

isolate->GetCurrentContext()->IsEmpty() doesn't work (I'm not fully sure why
however).

[haraken, 2016-06-07 00:23:19]

On 2016/06/07 00:15:24, ikilpatrick wrote:
> On 2016/06/06 23:21:14, haraken wrote:
> > LGTM
> > 
> > I guess that isolate->GetCurrentContext()->IsEmpty() would be a better check
> > though (because ScriptState::current uses the current context, not the
entered
> > context).
> 
> isolate->GetCurrentContext()->IsEmpty() doesn't work (I'm not fully sure why
> however).

Thanks. This is a super-edge case behavior in error handling, so I don't really
care :)

[ikilpatrick, 2016-06-07 00:25:57]

The CQ bit was checked by ikilpatrick@chromium.org

[commit-bot: I haz the power, 2016-06-07 00:26:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2039333002/1

[ikilpatrick, 2016-06-07 00:27:28]

On 2016/06/07 00:23:19, haraken wrote:
> On 2016/06/07 00:15:24, ikilpatrick wrote:
> > On 2016/06/06 23:21:14, haraken wrote:
> > > LGTM
> > > 
> > > I guess that isolate->GetCurrentContext()->IsEmpty() would be a better
check
> > > though (because ScriptState::current uses the current context, not the
> entered
> > > context).
> > 
> > isolate->GetCurrentContext()->IsEmpty() doesn't work (I'm not fully sure why
> > however).
> 
> Thanks. This is a super-edge case behavior in error handling, so I don't
really
> care :)

sg!

[commit-bot: I haz the power, 2016-06-07 01:32:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-07 01:32:58]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ikilpatrick, 2016-06-07 15:38:33]

The CQ bit was checked by ikilpatrick@chromium.org

[ikilpatrick, 2016-06-07 15:38:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, yhirano@chromium.org
Link to the patchset: https://codereview.chromium.org/2039333002/#ps20001
(title: "...now with test expectation.")

[commit-bot: I haz the power, 2016-06-07 15:38:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2039333002/20001

[commit-bot: I haz the power, 2016-06-07 16:04:25]

Description was changed from

==========
Fixes ASan crash for an embedded Blink-in-JS component.

In the test case (in this patch) it appears the Blink-in-JS component tries to
run JS during document creation.
However there is a ScriptForbidden scope which throws a "Uncaught Error: Script
execution is forbidden." (probably because it is being created in this weird
place?)

This patch re-adds the simple check that was removed in
https://codereview.chromium.org/1885833002 which checked if the
toDOMWindow(isolate->GetEnteredContext()) was null.
(now the check is just isolate->GetEnteredContext()->IsEmpty()).

BUG=617104
==========

to

==========
Fixes ASan crash for an embedded Blink-in-JS component.

In the test case (in this patch) it appears the Blink-in-JS component tries to
run JS during document creation.
However there is a ScriptForbidden scope which throws a "Uncaught Error: Script
execution is forbidden." (probably because it is being created in this weird
place?)

This patch re-adds the simple check that was removed in
https://codereview.chromium.org/1885833002 which checked if the
toDOMWindow(isolate->GetEnteredContext()) was null.
(now the check is just isolate->GetEnteredContext()->IsEmpty()).

BUG=617104
==========

[commit-bot: I haz the power, 2016-06-07 16:04:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-07 16:17:18]

Description was changed from

==========
Fixes ASan crash for an embedded Blink-in-JS component.

In the test case (in this patch) it appears the Blink-in-JS component tries to
run JS during document creation.
However there is a ScriptForbidden scope which throws a "Uncaught Error: Script
execution is forbidden." (probably because it is being created in this weird
place?)

This patch re-adds the simple check that was removed in
https://codereview.chromium.org/1885833002 which checked if the
toDOMWindow(isolate->GetEnteredContext()) was null.
(now the check is just isolate->GetEnteredContext()->IsEmpty()).

BUG=617104
==========

to

==========
Fixes ASan crash for an embedded Blink-in-JS component.

In the test case (in this patch) it appears the Blink-in-JS component tries to
run JS during document creation.
However there is a ScriptForbidden scope which throws a "Uncaught Error: Script
execution is forbidden." (probably because it is being created in this weird
place?)

This patch re-adds the simple check that was removed in
https://codereview.chromium.org/1885833002 which checked if the
toDOMWindow(isolate->GetEnteredContext()) was null.
(now the check is just isolate->GetEnteredContext()->IsEmpty()).

BUG=617104

Committed: https://crrev.com/2deeee5b5604eb997fa053a1b6ab4268c662596f
Cr-Commit-Position: refs/heads/master@{#398310}
==========

[commit-bot: I haz the power, 2016-06-07 16:17:20]

Patchset 2 (id:??) landed as
https://crrev.com/2deeee5b5604eb997fa053a1b6ab4268c662596f
Cr-Commit-Position: refs/heads/master@{#398310}