Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2257)

Unified Diff: content/browser/tracing/tracing_controller_impl.cc

Issue 2049143002: [memory-infra] Log reasons for memory dump failure (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Shorten constant name Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/tracing/child/child_memory_dump_manager_delegate_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/tracing/tracing_controller_impl.cc
diff --git a/content/browser/tracing/tracing_controller_impl.cc b/content/browser/tracing/tracing_controller_impl.cc
index e4c48115dd2de2f8124dae0af83161e35d34a05d..8380c45c44cd2924301ebd3b7e34f803daf23480 100644
--- a/content/browser/tracing/tracing_controller_impl.cc
+++ b/content/browser/tracing/tracing_controller_impl.cc
@@ -922,8 +922,9 @@ void TracingControllerImpl::RequestGlobalMemoryDump(
}
// Abort if another dump is already in progress.
if (pending_memory_dump_guid_) {
- DVLOG(1) << "Requested memory dump " << args.dump_guid
- << " while waiting for " << pending_memory_dump_guid_;
+ VLOG(1) << base::trace_event::MemoryDumpManager::kLogPrefix
+ << " (" << args.dump_guid << ") aborted because another dump ("
+ << pending_memory_dump_guid_ << ") is in progress";
if (!callback.is_null())
callback.Run(args.dump_guid, false /* success */);
return;
@@ -1001,8 +1002,9 @@ void TracingControllerImpl::OnProcessMemoryDumpResponse(
pending_memory_dump_filters_.erase(it);
if (!success) {
++failed_memory_dump_count_;
- DLOG(WARNING) << "Global memory dump failed because of NACK from child "
- << trace_message_filter->peer_pid();
+ VLOG(1) << base::trace_event::MemoryDumpManager::kLogPrefix
+ << " failed because of NACK from child "
+ << trace_message_filter->peer_pid();
}
FinalizeGlobalMemoryDumpIfAllProcessesReplied();
}
@@ -1013,7 +1015,8 @@ void TracingControllerImpl::OnBrowserProcessMemoryDumpDone(uint64_t dump_guid,
--pending_memory_dump_ack_count_;
if (!success) {
++failed_memory_dump_count_;
- DLOG(WARNING) << "Global memory dump aborted on the current process";
+ VLOG(1) << base::trace_event::MemoryDumpManager::kLogPrefix
+ << " aborted on the current process";
}
FinalizeGlobalMemoryDumpIfAllProcessesReplied();
}
« no previous file with comments | « components/tracing/child/child_memory_dump_manager_delegate_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698