Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: components/tracing/child/child_memory_dump_manager_delegate_impl.cc

Issue 2049143002: [memory-infra] Log reasons for memory dump failure (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Shorten constant name Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/trace_event/memory_dump_manager.cc ('k') | content/browser/tracing/tracing_controller_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/tracing/child/child_memory_dump_manager_delegate_impl.cc
diff --git a/components/tracing/child/child_memory_dump_manager_delegate_impl.cc b/components/tracing/child/child_memory_dump_manager_delegate_impl.cc
index c2824f1bd8f6271a3ddf282a5e3735af8d92e58f..20078e7c32e8f34d54deb65b6e8916c8c58d8a94 100644
--- a/components/tracing/child/child_memory_dump_manager_delegate_impl.cc
+++ b/components/tracing/child/child_memory_dump_manager_delegate_impl.cc
@@ -75,8 +75,12 @@ void ChildMemoryDumpManagerDelegateImpl::RequestGlobalMemoryDump(
// Bail out if we receive a dump request from the manager before the
// ChildTraceMessageFilter has been initialized.
- if (!ctmf_task_runner)
+ if (!ctmf_task_runner) {
+ VLOG(1) << base::trace_event::MemoryDumpManager::kLogPrefix
+ << " failed because child trace message filter hasn't been"
+ << " initialized";
return AbortDumpRequest(args, callback);
+ }
// Make sure we access |ctmf_| only on the thread where it lives to avoid
// races on shutdown.
@@ -92,8 +96,12 @@ void ChildMemoryDumpManagerDelegateImpl::RequestGlobalMemoryDump(
// The ChildTraceMessageFilter could have been destroyed while hopping on the
// right thread. If this is the case, bail out.
- if (!ctmf_)
+ if (!ctmf_) {
+ VLOG(1) << base::trace_event::MemoryDumpManager::kLogPrefix
+ << " failed because child trace message filter was"
+ << " destroyed while switching threads";
return AbortDumpRequest(args, callback);
+ }
// Send the request up to the browser process' MessageDumpmanager.
ctmf_->SendGlobalMemoryDumpRequest(args, callback);
« no previous file with comments | « base/trace_event/memory_dump_manager.cc ('k') | content/browser/tracing/tracing_controller_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698