Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 2049083002: Implement MusGpuMemoryBufferManager (Closed)

Created:
4 years, 6 months ago by Peng
Modified:
4 years, 6 months ago
CC:
chromium-reviews, rjkroege, piman+watch_chromium.org, sdefresne+watchlist_chromium.org, droger+watchlist_chromium.org, blundell+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement MusGpuMemoryBufferManager. Implement the MusGpuMemoryBufferManager which is used by MUS locally. It supports allocating Native GpuMemoryBuffer(Ozone, etc). It is needed for ChromeBook/ozone native rendering. BUG=618316 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/cab01d28306bdec109b957d17d64d68677d9d3ed Cr-Commit-Position: refs/heads/master@{#399390}

Patch Set 1 #

Patch Set 2 : Update #

Patch Set 3 : Update #

Patch Set 4 : Update #

Total comments: 2

Patch Set 5 : Update #

Patch Set 6 : Update #

Total comments: 6

Patch Set 7 : Update #

Patch Set 8 : Rebase #

Total comments: 2

Patch Set 9 : Update #

Total comments: 3

Patch Set 10 : Update #

Patch Set 11 : Update the mojom document #

Unified diffs Side-by-side diffs Delta from patch set Stats (+277 lines, -51 lines) Patch
M components/mus/common/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
A components/mus/common/generic_shared_memory_id_generator.h View 1 chunk +19 lines, -0 lines 0 comments Download
A + components/mus/common/generic_shared_memory_id_generator.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/mus/common/gpu_service.cc View 1 2 3 4 5 6 7 8 9 2 chunks +9 lines, -22 lines 0 comments Download
M components/mus/gpu/BUILD.gn View 1 2 3 3 chunks +7 lines, -0 lines 0 comments Download
M components/mus/gpu/DEPS View 1 chunk +13 lines, -1 line 0 comments Download
M components/mus/gpu/gpu_service_mus.h View 3 chunks +10 lines, -2 lines 0 comments Download
M components/mus/gpu/gpu_service_mus.cc View 1 2 3 4 5 6 7 4 chunks +12 lines, -2 lines 0 comments Download
A + components/mus/gpu/mus_gpu_memory_buffer_manager.h View 1 2 3 4 5 6 2 chunks +25 lines, -11 lines 0 comments Download
A components/mus/gpu/mus_gpu_memory_buffer_manager.cc View 1 2 3 4 5 6 7 8 1 chunk +123 lines, -0 lines 0 comments Download
M components/mus/public/interfaces/gpu_service.mojom View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -1 line 0 comments Download
M components/mus/surfaces/direct_output_surface_ozone.h View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/surfaces/direct_output_surface_ozone.cc View 2 chunks +13 lines, -6 lines 0 comments Download
M components/mus/surfaces/surfaces_context_provider.h View 1 4 chunks +13 lines, -1 line 0 comments Download
M components/mus/surfaces/surfaces_context_provider.cc View 1 2 3 4 5 6 2 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 65 (27 generated)
Peng
Hi Robert, PTAL. Thanks.
4 years, 6 months ago (2016-06-08 18:42:19 UTC) #9
rjkroege
LGTM with nit. (I presumed that you tested it on device. :-) https://codereview.chromium.org/2049083002/diff/100001/components/mus/gpu/gpu_service_mus.cc File components/mus/gpu/gpu_service_mus.cc ...
4 years, 6 months ago (2016-06-08 21:16:43 UTC) #10
Peng
https://codereview.chromium.org/2049083002/diff/100001/components/mus/gpu/gpu_service_mus.cc File components/mus/gpu/gpu_service_mus.cc (right): https://codereview.chromium.org/2049083002/diff/100001/components/mus/gpu/gpu_service_mus.cc#newcode214 components/mus/gpu/gpu_service_mus.cc:214: #if defined(USE_OZONE) On 2016/06/08 21:16:43, rjkroege wrote: > It ...
4 years, 6 months ago (2016-06-08 21:40:36 UTC) #11
Peng
On 2016/06/08 21:16:43, rjkroege wrote: > LGTM with nit. > > (I presumed that you ...
4 years, 6 months ago (2016-06-08 21:41:16 UTC) #12
Peng
+piman for omponents/mus/gpu/DEPS, welcome to review other files as well. Hi Antoine, PTAL. Thanks.
4 years, 6 months ago (2016-06-08 21:43:15 UTC) #13
Peng
4 years, 6 months ago (2016-06-08 21:43:34 UTC) #15
Peng
On 2016/06/08 21:43:34, Peng wrote: +piman for omponents/mus/gpu/DEPS, welcome to review other files as well. ...
4 years, 6 months ago (2016-06-08 21:44:04 UTC) #16
Peng
+jam for base/threading/* & components/mus/common/* Hi John, PTAL. Thanks.
4 years, 6 months ago (2016-06-09 15:05:16 UTC) #18
jam
On 2016/06/09 15:05:16, Peng wrote: > +jam for base/threading/* & components/mus/common/* please pick a components/mus ...
4 years, 6 months ago (2016-06-09 16:01:46 UTC) #19
Peng
https://codereview.chromium.org/2049083002/diff/140001/components/mus/common/gpu_service.cc File components/mus/common/gpu_service.cc (right): https://codereview.chromium.org/2049083002/diff/140001/components/mus/common/gpu_service.cc#newcode78 components/mus/common/gpu_service.cc:78: base::ThreadRestrictions::ScopedAllowWait allow_wait; On 2016/06/09 16:01:45, jam wrote: > why ...
4 years, 6 months ago (2016-06-09 17:40:29 UTC) #20
piman
lgtm https://codereview.chromium.org/2049083002/diff/140001/components/mus/gpu/mus_gpu_memory_buffer_manager.cc File components/mus/gpu/mus_gpu_memory_buffer_manager.cc (right): https://codereview.chromium.org/2049083002/diff/140001/components/mus/gpu/mus_gpu_memory_buffer_manager.cc#newcode64 components/mus/gpu/mus_gpu_memory_buffer_manager.cc:64: GpuServiceMus::GetInstance()->gpu_memory_buffer_factory(); nit: because MusGpuMemoryBufferManager is created by GpuServiceMus, ...
4 years, 6 months ago (2016-06-09 19:31:33 UTC) #21
Peng
https://codereview.chromium.org/2049083002/diff/140001/components/mus/gpu/mus_gpu_memory_buffer_manager.cc File components/mus/gpu/mus_gpu_memory_buffer_manager.cc (right): https://codereview.chromium.org/2049083002/diff/140001/components/mus/gpu/mus_gpu_memory_buffer_manager.cc#newcode64 components/mus/gpu/mus_gpu_memory_buffer_manager.cc:64: GpuServiceMus::GetInstance()->gpu_memory_buffer_factory(); On 2016/06/09 19:31:32, piman OOO back 2016-6-9 wrote: ...
4 years, 6 months ago (2016-06-09 20:32:46 UTC) #22
piman
https://codereview.chromium.org/2049083002/diff/180001/components/mus/gpu/mus_gpu_memory_buffer_manager.cc File components/mus/gpu/mus_gpu_memory_buffer_manager.cc (right): https://codereview.chromium.org/2049083002/diff/180001/components/mus/gpu/mus_gpu_memory_buffer_manager.cc#newcode120 components/mus/gpu/mus_gpu_memory_buffer_manager.cc:120: GpuServiceMus::GetInstance()->gpu_channel_manager(); nit: here too :)
4 years, 6 months ago (2016-06-09 20:47:55 UTC) #23
Peng
https://codereview.chromium.org/2049083002/diff/180001/components/mus/gpu/mus_gpu_memory_buffer_manager.cc File components/mus/gpu/mus_gpu_memory_buffer_manager.cc (right): https://codereview.chromium.org/2049083002/diff/180001/components/mus/gpu/mus_gpu_memory_buffer_manager.cc#newcode120 components/mus/gpu/mus_gpu_memory_buffer_manager.cc:120: GpuServiceMus::GetInstance()->gpu_channel_manager(); On 2016/06/09 20:47:55, piman OOO back 2016-6-9 wrote: ...
4 years, 6 months ago (2016-06-09 21:01:37 UTC) #24
piman
lgtm
4 years, 6 months ago (2016-06-09 21:33:24 UTC) #25
Fady Samuel
https://codereview.chromium.org/2049083002/diff/200001/components/mus/common/gpu_service.cc File components/mus/common/gpu_service.cc (right): https://codereview.chromium.org/2049083002/diff/200001/components/mus/common/gpu_service.cc#newcode74 components/mus/common/gpu_service.cc:74: gpu_service->EstablishGpuChannel(base::Bind( Can't we just make this sync?
4 years, 6 months ago (2016-06-10 15:23:03 UTC) #27
jam
https://codereview.chromium.org/2049083002/diff/200001/components/mus/common/gpu_service.cc File components/mus/common/gpu_service.cc (right): https://codereview.chromium.org/2049083002/diff/200001/components/mus/common/gpu_service.cc#newcode74 components/mus/common/gpu_service.cc:74: gpu_service->EstablishGpuChannel(base::Bind( On 2016/06/10 15:23:02, Fady Samuel wrote: > Can't ...
4 years, 6 months ago (2016-06-10 15:31:16 UTC) #28
Peng
https://codereview.chromium.org/2049083002/diff/200001/components/mus/common/gpu_service.cc File components/mus/common/gpu_service.cc (right): https://codereview.chromium.org/2049083002/diff/200001/components/mus/common/gpu_service.cc#newcode74 components/mus/common/gpu_service.cc:74: gpu_service->EstablishGpuChannel(base::Bind( Done
4 years, 6 months ago (2016-06-10 17:39:30 UTC) #29
Peng
+tsepez for gpu_service.mojom Hi Tom. PTAL. Thanks.
4 years, 6 months ago (2016-06-10 17:41:19 UTC) #31
Tom Sepez
mojom lgtm
4 years, 6 months ago (2016-06-10 18:09:10 UTC) #32
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2049083002/240001
4 years, 6 months ago (2016-06-10 18:21:16 UTC) #34
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-10 19:53:33 UTC) #36
Peng
On 2016/06/10 19:53:33, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 6 months ago (2016-06-10 20:59:25 UTC) #37
jam
On 2016/06/10 20:59:25, Peng wrote: > On 2016/06/10 19:53:33, commit-bot: I haz the power wrote: ...
4 years, 6 months ago (2016-06-10 23:41:45 UTC) #38
chromium-reviews
I think piman and Rob are enough, but I still need lgtm form an owner ...
4 years, 6 months ago (2016-06-10 23:59:44 UTC) #39
Peng
+Ben for mus/common. Hi Ben, PTAL. Thanks.
4 years, 6 months ago (2016-06-11 00:30:00 UTC) #41
Ben Goodger (Google)
lgtm
4 years, 6 months ago (2016-06-12 02:07:13 UTC) #42
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2049083002/240001
4 years, 6 months ago (2016-06-12 02:08:58 UTC) #45
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/245324)
4 years, 6 months ago (2016-06-12 03:21:37 UTC) #47
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2049083002/240001
4 years, 6 months ago (2016-06-12 11:05:06 UTC) #49
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/245349)
4 years, 6 months ago (2016-06-12 12:09:41 UTC) #51
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2049083002/240001
4 years, 6 months ago (2016-06-12 12:14:15 UTC) #53
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/245352)
4 years, 6 months ago (2016-06-12 13:15:35 UTC) #55
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2049083002/240001
4 years, 6 months ago (2016-06-12 13:29:02 UTC) #57
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/245359)
4 years, 6 months ago (2016-06-12 14:30:53 UTC) #59
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2049083002/240001
4 years, 6 months ago (2016-06-12 14:44:28 UTC) #61
commit-bot: I haz the power
Committed patchset #11 (id:240001)
4 years, 6 months ago (2016-06-12 15:17:02 UTC) #63
commit-bot: I haz the power
4 years, 6 months ago (2016-06-12 15:19:54 UTC) #65
Message was sent while issue was closed.
Patchset 11 (id:??) landed as
https://crrev.com/cab01d28306bdec109b957d17d64d68677d9d3ed
Cr-Commit-Position: refs/heads/master@{#399390}

Powered by Google App Engine
This is Rietveld 408576698