Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Issue 2049053004: AVDACodecImages keep their backing SurfaceTexture alive (Closed)

Created:
4 years, 6 months ago by watk
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

AVDACodecImages keep their backing SurfaceTexture alive Previously, when destructing an AVDA, we had to delete the AVDACodecImages attached to the PictureBuffer textures, and use a fragile method of copying the SurfaceTexture buffer and creating egl images to make sure those PictureBuffer textures didn't become unbacked. Now the AVDACodecImages are kept alive by the Textures they're bound to, and they keep a ref to AVDASharedState which contains the shared SurfaceTexture and its platform texture. The AVDASharedState destructor cleans up the SurfaceTexture and deletes the platform texture. BUG=533630, 614090 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2005103004 Cr-Commit-Position: refs/heads/master@{#398293} (cherry picked from commit 3e465933721f2732fc422029529b80fc9784e812) Committed: https://chromium.googlesource.com/chromium/src/+/89c1f3f09b3fa5fd49e5c07415f5a9e48a29cd20

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : fixed gl->gfx renames #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -248 lines) Patch
M media/gpu/android_copying_backing_strategy.cc View 1 chunk +2 lines, -17 lines 0 comments Download
M media/gpu/android_deferred_rendering_backing_strategy.cc View 5 chunks +29 lines, -177 lines 0 comments Download
M media/gpu/android_video_decode_accelerator.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M media/gpu/android_video_decode_accelerator.cc View 1 2 1 chunk +28 lines, -0 lines 0 comments Download
M media/gpu/avda_codec_image.h View 1 chunk +2 lines, -0 lines 0 comments Download
M media/gpu/avda_codec_image.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M media/gpu/avda_shared_state.h View 5 chunks +13 lines, -34 lines 0 comments Download
M media/gpu/avda_shared_state.cc View 2 chunks +17 lines, -7 lines 0 comments Download
M media/gpu/avda_state_provider.h View 1 2 3 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
watk
4 years, 6 months ago (2016-06-09 00:17:31 UTC) #2
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
89c1f3f09b3fa5fd49e5c07415f5a9e48a29cd20.

Powered by Google App Engine
This is Rietveld 408576698