Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Unified Diff: xfa/fxbarcode/common/BC_CommonECI.cpp

Issue 2048983002: Get rid of NULLs in xfa/fxbarcode/ (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: more cleanup Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: xfa/fxbarcode/common/BC_CommonECI.cpp
diff --git a/xfa/fxbarcode/common/BC_CommonECI.cpp b/xfa/fxbarcode/common/BC_CommonECI.cpp
index 4e37aec566bd852320bb9f91a48e42909ec66c93..d8e2504acac128f0e768fd318101c36c140bbeea 100644
--- a/xfa/fxbarcode/common/BC_CommonECI.cpp
+++ b/xfa/fxbarcode/common/BC_CommonECI.cpp
@@ -34,9 +34,7 @@ int32_t CBC_CommonECI::GetValue() {
CBC_CommonECI* CBC_CommonECI::GetEICByValue(int32_t value, int32_t& e) {
if (value < 0 || value > 999999) {
e = BCExceptionBadECI;
- return NULL;
+ return nullptr;
dsinclair 2016/06/09 18:40:06 nit: this can be removed since we always return nu
Lei Zhang 2016/06/09 22:31:47 I suspect CBC_CommonECI is not all that useful. I'
}
- if (value < 900) {
- }
- return NULL;
+ return nullptr;
}

Powered by Google App Engine
This is Rietveld 408576698