Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2048793002: Remove settings button from Physical Web Activity (Closed)

Created:
4 years, 6 months ago by cco3
Modified:
4 years, 6 months ago
Reviewers:
nyquist, mattreynolds
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove settings button from Physical Web Activity Other features in chromium don't link to the settings page, so for consistency, the Physical Web shouldn't either. BUG=618079 Committed: https://crrev.com/b0f304cf34c7a20dcab2f8de8f4941521c6a0f9b Cr-Commit-Position: refs/heads/master@{#400850}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Change order ID to be tighter. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -14 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java View 1 3 chunks +1 line, -14 lines 2 comments Download

Messages

Total messages: 15 (4 generated)
cco3
4 years, 6 months ago (2016-06-15 22:53:51 UTC) #2
mattreynolds
https://codereview.chromium.org/2048793002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java File chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java (left): https://codereview.chromium.org/2048793002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java#oldcode147 chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java:147: menu.add(0, R.id.menu_id_close, 3, R.string.close) Could you set the order ...
4 years, 6 months ago (2016-06-15 22:59:40 UTC) #3
mattreynolds
lgtm
4 years, 6 months ago (2016-06-16 01:02:32 UTC) #4
cco3
4 years, 6 months ago (2016-06-16 17:09:40 UTC) #6
cco3
Sorry for the vacillation!
4 years, 6 months ago (2016-06-16 17:10:02 UTC) #7
nyquist
https://codereview.chromium.org/2048793002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java File chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java (left): https://codereview.chromium.org/2048793002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java#oldcode143 chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java:143: menu.add(0, R.id.menu_id_settings, 2, R.string.menu_preferences) Should the string and ID ...
4 years, 6 months ago (2016-06-17 23:18:07 UTC) #8
cco3
https://codereview.chromium.org/2048793002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java File chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java (left): https://codereview.chromium.org/2048793002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java#oldcode143 chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java:143: menu.add(0, R.id.menu_id_settings, 2, R.string.menu_preferences) On 2016/06/17 23:18:06, nyquist wrote: ...
4 years, 6 months ago (2016-06-17 23:48:36 UTC) #9
nyquist
lgtm
4 years, 6 months ago (2016-06-20 23:29:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2048793002/20001
4 years, 6 months ago (2016-06-20 23:30:24 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-21 00:21:57 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-21 00:25:48 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b0f304cf34c7a20dcab2f8de8f4941521c6a0f9b
Cr-Commit-Position: refs/heads/master@{#400850}

Powered by Google App Engine
This is Rietveld 408576698