Remove settings button from Physical Web Activity

Remove settings button from Physical Web Activity

Other features in chromium don't link to the settings page, so for
consistency, the Physical Web shouldn't either.

BUG=618079
Committed: https://crrev.com/b0f304cf34c7a20dcab2f8de8f4941521c6a0f9b
Cr-Commit-Position: refs/heads/master@{#400850}

[cco3, 2016-06-15 22:53:51]

cco3@chromium.org changed reviewers:
+ mattreynolds@chromium.org

[mattreynolds, 2016-06-15 22:59:40]

https://codereview.chromium.org/2048793002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java
(left):

https://codereview.chromium.org/2048793002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java:147:
menu.add(0, R.id.menu_id_close, 3, R.string.close)
Could you set the order param back to 2 on the close item?

[mattreynolds, 2016-06-16 01:02:32]

lgtm

[cco3, 2016-06-16 17:09:40]

cco3@chromium.org changed reviewers:
+ nyquist@chromium.org

[cco3, 2016-06-16 17:10:02]

Sorry for the vacillation!

[nyquist, 2016-06-17 23:18:07]

https://codereview.chromium.org/2048793002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java
(left):

https://codereview.chromium.org/2048793002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java:143:
menu.add(0, R.id.menu_id_settings, 2, R.string.menu_preferences)
Should the string and ID also be removed?

[cco3, 2016-06-17 23:48:36]

https://codereview.chromium.org/2048793002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java
(left):

https://codereview.chromium.org/2048793002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java:143:
menu.add(0, R.id.menu_id_settings, 2, R.string.menu_preferences)
On 2016/06/17 23:18:06, nyquist wrote:
> Should the string and ID also be removed?

I don't *think* so...do you think I should?  They are pretty generic names.

[nyquist, 2016-06-20 23:29:28]

lgtm

[cco3, 2016-06-20 23:29:58]

The CQ bit was checked by cco3@chromium.org

[commit-bot: I haz the power, 2016-06-20 23:30:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2048793002/20001

[commit-bot: I haz the power, 2016-06-21 00:21:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-21 00:25:42]

Description was changed from

==========
Remove settings button from Physical Web Activity

Other features in chromium don't link to the settings page, so for
consistency, the Physical Web shouldn't either.

BUG=618079
==========

to

==========
Remove settings button from Physical Web Activity

Other features in chromium don't link to the settings page, so for
consistency, the Physical Web shouldn't either.

BUG=618079

Committed: https://crrev.com/b0f304cf34c7a20dcab2f8de8f4941521c6a0f9b
Cr-Commit-Position: refs/heads/master@{#400850}
==========

[commit-bot: I haz the power, 2016-06-21 00:25:48]

Patchset 2 (id:??) landed as
https://crrev.com/b0f304cf34c7a20dcab2f8de8f4941521c6a0f9b
Cr-Commit-Position: refs/heads/master@{#400850}