Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1237)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java

Issue 2048793002: Remove settings button from Physical Web Activity (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Change order ID to be tighter. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java
index 427e9af81456bc3094a29e3445de23d97b2734dc..9900cd90ca00ce633d7a00368d9e3ac07489d2cc 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/ListUrlsActivity.java
@@ -33,8 +33,6 @@ import org.chromium.base.Log;
import org.chromium.base.VisibleForTesting;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.ChromeApplication;
-import org.chromium.chrome.browser.preferences.PreferencesLauncher;
-import org.chromium.chrome.browser.preferences.privacy.PhysicalWebPreferenceFragment;
import org.chromium.chrome.browser.widget.FadingShadow;
import org.chromium.chrome.browser.widget.FadingShadowView;
@@ -138,13 +136,7 @@ public class ListUrlsActivity extends AppCompatActivity implements AdapterView.O
.setIcon(tintedRefresh)
.setShowAsActionFlags(MenuItem.SHOW_AS_ACTION_ALWAYS);
- Drawable tintedSettings = ContextCompat.getDrawable(this, R.drawable.settings_cog);
- tintedSettings.setColorFilter(tintColor, PorterDuff.Mode.SRC_IN);
- menu.add(0, R.id.menu_id_settings, 2, R.string.menu_preferences)
nyquist 2016/06/17 23:18:06 Should the string and ID also be removed?
cco3 2016/06/17 23:48:36 I don't *think* so...do you think I should? They
- .setIcon(tintedSettings)
- .setShowAsActionFlags(MenuItem.SHOW_AS_ACTION_IF_ROOM);
-
- menu.add(0, R.id.menu_id_close, 3, R.string.close)
+ menu.add(0, R.id.menu_id_close, 2, R.string.close)
.setIcon(R.drawable.btn_close)
.setShowAsActionFlags(MenuItem.SHOW_AS_ACTION_ALWAYS);
@@ -160,11 +152,6 @@ public class ListUrlsActivity extends AppCompatActivity implements AdapterView.O
} else if (id == R.id.menu_id_refresh) {
startRefresh(true, false);
return true;
- } else if (id == R.id.menu_id_settings) {
- Intent intent = PreferencesLauncher.createIntentForSettingsPage(
- this, PhysicalWebPreferenceFragment.class.getName());
- startActivity(intent);
- return true;
}
Log.e(TAG, "Unknown menu item selected");
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698