Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: third_party/WebKit/LayoutTests/fast/events/shift-drag-selection-on-image-triggers-drag-n-drop.html

Issue 2048733002: Selecting with shift+drag results in unexpected drag-n-drop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Selecting with shift+drag results in unexpected drag-n-drop Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/events/shift-drag-selection-on-image-triggers-drag-n-drop.html
diff --git a/third_party/WebKit/LayoutTests/fast/events/shift-drag-selection-on-image-triggers-drag-n-drop.html b/third_party/WebKit/LayoutTests/fast/events/shift-drag-selection-on-image-triggers-drag-n-drop.html
new file mode 100644
index 0000000000000000000000000000000000000000..2d34fec8ca6101e56ad02633ced6618cb31368fe
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/fast/events/shift-drag-selection-on-image-triggers-drag-n-drop.html
@@ -0,0 +1,41 @@
+<!DOCTYPE html>
+<script src="../../resources/testharness.js"></script>
+<script src="../../resources/testharnessreport.js"></script>
+<p>This test ensures drag-n-drop does start when extending an existing selecting with shift + mouse drag, starting over an image.</p>
+<span style='font-size: 30px; padding: 10px;'>Some text with an image <img src="resources/abe.png" width="50" height="50"> at end.</span>
+<div id="log"></div>
+
+<script>
+test(function() {
+ assert_not_equals(window.testRunner, undefined, 'Requires testRunner.');
+ assert_not_equals(window.eventSender, undefined, 'Requires eventSender.');
+
+ var span = document.getElementsByTagName('span')[0];
yosin_UTC9 2016/06/28 01:09:14 nit: document.querySelector('span') is shorter. It
tonikitoo 2016/06/29 02:49:51 Done.
+ span.focus();
+
+ var img = document.getElementsByTagName('img')[0];
yosin_UTC9 2016/06/28 01:09:14 nit: document.querySelector('img') is shorter. It
tonikitoo 2016/06/29 02:49:51 Done.
+
+ var dragStartCount = 0;
+ document.addEventListener('dragstart', function (event) { dragStartCount++; });
+
+ var y = span.offsetTop + span.offsetHeight / 2;
+ eventSender.mouseMoveTo(span.offsetLeft + 5, y);
+ eventSender.mouseDown();
+ eventSender.leapForward(200);
+ eventSender.mouseUp();
+
+ eventSender.mouseMoveTo(span.offsetLeft + span.offsetWidth / 4, y);
+ eventSender.mouseDown(0, ['shiftKey']);
+ eventSender.leapForward(200);
+ eventSender.mouseUp();
+
+ eventSender.mouseMoveTo(img.offsetLeft + img.offsetWidth / 2 , y);
+ eventSender.mouseDown(0, ['shiftKey']);
+ eventSender.leapForward(200);
+ eventSender.mouseMoveTo(img.offsetLeft + img.offsetWidth / 2 , y + 120);
+ eventSender.leapForward(200);
+ eventSender.mouseUp();
+
+ assert_equals(dragStartCount, 1);
+});
+</script>

Powered by Google App Engine
This is Rietveld 408576698