third_party/WebKit/LayoutTests/fast/events/shift-drag-selection-on-image-triggers-drag-n-drop.html - Issue 2048733002: Selecting with shift+drag results in unexpected drag-n-drop

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/events/shift-drag-selection-on-image-triggers-drag-n-drop.html

Issue 2048733002: Selecting with shift+drag results in unexpected drag-n-drop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Selecting with shift+drag results in unexpected drag-n-drop Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/events/shift-drag-selection-no-drag-n-drop.html ('k') | third_party/WebKit/LayoutTests/fast/events/shift-drag-selection-on-link-triggers-drag-n-drop.html » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <p>This test ensures drag-n-drop does start when extending an existing selecting with shift + mouse drag, starting over an image.</p>

	5 <span style='font-size: 30px; padding: 10px;'>Some text with an image <img src=" resources/abe.png" width="50" height="50"> at end.</span>

	6 <div id="log"></div>

	7

	8 <script>

	9 test(function() {

	10 assert_not_equals(window.testRunner, undefined, 'Requires testRunner.');

	11 assert_not_equals(window.eventSender, undefined, 'Requires eventSender.');

	12

	13 var span = document.getElementsByTagName('span')[0];
	yosin_UTC9 2016/06/28 01:09:14 nit: document.querySelector('span') is shorter. It nit: document.querySelector('span') is shorter. It is better to use "id" attribute and document.getElementById() or document.querySelector('#foo') to be more specific. tonikitoo 2016/06/29 02:49:51 Done. Show quoted text On 2016/06/28 01:09:14, Yosi_UTC9 wrote: > nit: document.querySelector('span') is shorter. > It is better to use "id" attribute and document.getElementById() or > document.querySelector('#foo') to be more specific. Done.
	14 span.focus();

	15

	16 var img = document.getElementsByTagName('img')[0];
	yosin_UTC9 2016/06/28 01:09:14 nit: document.querySelector('img') is shorter. It nit: document.querySelector('img') is shorter. It is better to use "id" attribute and document.getElementById() or document.querySelector('#foo') to be more specific. tonikitoo 2016/06/29 02:49:51 Done. Show quoted text On 2016/06/28 01:09:14, Yosi_UTC9 wrote: > nit: document.querySelector('img') is shorter. > It is better to use "id" attribute and document.getElementById() or > document.querySelector('#foo') to be more specific. Done.
	17

	18 var dragStartCount = 0;

	19 document.addEventListener('dragstart', function (event) { dragStartCount++; });

	20

	21 var y = span.offsetTop + span.offsetHeight / 2;

	22 eventSender.mouseMoveTo(span.offsetLeft + 5, y);

	23 eventSender.mouseDown();

	24 eventSender.leapForward(200);

	25 eventSender.mouseUp();

	26

	27 eventSender.mouseMoveTo(span.offsetLeft + span.offsetWidth / 4, y);

	28 eventSender.mouseDown(0, ['shiftKey']);

	29 eventSender.leapForward(200);

	30 eventSender.mouseUp();

	31

	32 eventSender.mouseMoveTo(img.offsetLeft + img.offsetWidth / 2 , y);

	33 eventSender.mouseDown(0, ['shiftKey']);

	34 eventSender.leapForward(200);

	35 eventSender.mouseMoveTo(img.offsetLeft + img.offsetWidth / 2 , y + 120);

	36 eventSender.leapForward(200);

	37 eventSender.mouseUp();

	38

	39 assert_equals(dragStartCount, 1);

	40 });

	41 </script>

OLD	NEW