third_party/WebKit/Source/core/editing/SelectionController.h - Issue 2048733002: Selecting with shift+drag results in unexpected drag-n-drop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/SelectionController.h

Issue 2048733002: Selecting with shift+drag results in unexpected drag-n-drop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/events/shift-drag-selection-no-drag-n-drop.html ('K') | « third_party/WebKit/LayoutTests/fast/events/shift-drag-selection-on-link-triggers-drag-n-drop-expected.txt ('k') | third_party/WebKit/Source/core/editing/SelectionController.cpp » ('j') | third_party/WebKit/Source/core/editing/SelectionController.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/SelectionController.h

diff --git a/third_party/WebKit/Source/core/editing/SelectionController.h b/third_party/WebKit/Source/core/editing/SelectionController.h

index 796df9dec1acead424ec1cc5369d4bc3ffb1b2fb..8e28131c12a60d34bc042fd302d52d24084b6f98 100644

--- a/third_party/WebKit/Source/core/editing/SelectionController.h

+++ b/third_party/WebKit/Source/core/editing/SelectionController.h

@@ -91,6 +91,8 @@ private:

bool isLinkSelection(const MouseEventWithHitTestResults&);

yosin_UTC9 2016/06/08 01:37:22 nit: no need to have an extra blank line here.

tonikitoo 2016/06/24 18:39:20 Done.

+bool isExtendingSelection(const MouseEventWithHitTestResults&);

} // namespace blink

#endif // SelectionController_h