third_party/WebKit/Source/core/editing/SelectionController.h - Issue 2048733002: Selecting with shift+drag results in unexpected drag-n-drop

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/editing/SelectionController.h

Issue 2048733002: Selecting with shift+drag results in unexpected drag-n-drop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/fast/events/shift-drag-selection-no-drag-n-drop.html ('K') | « third_party/WebKit/LayoutTests/fast/events/shift-drag-selection-on-link-triggers-drag-n-drop-expected.txt ('k') | third_party/WebKit/Source/core/editing/SelectionController.cpp » ('j') | third_party/WebKit/Source/core/editing/SelectionController.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved.	2 * Copyright (C) 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved.

3 * Copyright (C) 2015 Google Inc. All rights reserved.	3 * Copyright (C) 2015 Google Inc. All rights reserved.

4 *	4 *

5 * Redistribution and use in source and binary forms, with or without	5 * Redistribution and use in source and binary forms, with or without

6 * modification, are permitted provided that the following conditions	6 * modification, are permitted provided that the following conditions

7 * are met:	7 * are met:

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 72 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
83	83

84 Member<LocalFrame> const m_frame;	84 Member<LocalFrame> const m_frame;

85 bool m_mouseDownMayStartSelect;	85 bool m_mouseDownMayStartSelect;

86 bool m_mouseDownWasSingleClickInSelection;	86 bool m_mouseDownWasSingleClickInSelection;

87 bool m_mouseDownAllowsMultiClick;	87 bool m_mouseDownAllowsMultiClick;

88 enum class SelectionState { HaveNotStartedSelection, PlacedCaret, ExtendedSe lection };	88 enum class SelectionState { HaveNotStartedSelection, PlacedCaret, ExtendedSe lection };

89 SelectionState m_selectionState;	89 SelectionState m_selectionState;

90 };	90 };

91	91

92 bool isLinkSelection(const MouseEventWithHitTestResults&);	92 bool isLinkSelection(const MouseEventWithHitTestResults&);

93	93
	yosin_UTC9 2016/06/08 01:37:22 nit: no need to have an extra blank line here. nit: no need to have an extra blank line here. tonikitoo 2016/06/24 18:39:20 Done. Show quoted text On 2016/06/08 01:37:22, Yosi_UTC9 wrote: > nit: no need to have an extra blank line here. Done.
	94 bool isExtendingSelection(const MouseEventWithHitTestResults&);

	95

94 } // namespace blink	96 } // namespace blink

95	97

96 #endif // SelectionController_h	98 #endif // SelectionController_h

OLD	NEW