Misc. omnibox cleanup:

Misc. omnibox cleanup:

* NULL -> nullptr
* unix_hacker()-style functions should be inlined
* Add convenience wrapper in OmniboxEditModel for popup IsOpen() checks and use
  it everywhere (this results in us adding null checks in a few places that
  didn't have them, which is necessary for an upcoming change)
* UTF8ToUTF16() -> ASCIIToUTF16()
* Avoid using directives
* Collapse common setup in edit unittests into the test base class

BUG=none
TEST=none

Committed: https://crrev.com/5c074479ad4691cda5033a909d33727572c7997b
Cr-Commit-Position: refs/heads/master@{#398999}

[Peter Kasting, 2016-06-08 01:11:20]

pkasting@chromium.org changed reviewers:
+ mpearson@chromium.org

[Peter Kasting, 2016-06-08 01:11:21]

https://codereview.chromium.org/2048693003/diff/1/components/omnibox/browser/...
File components/omnibox/browser/omnibox_edit_unittest.cc (right):

https://codereview.chromium.org/2048693003/diff/1/components/omnibox/browser/...
components/omnibox/browser/omnibox_edit_unittest.cc:343: // Test if the model
updates the inline autocomplete text in the view.
It's hard to see in this diff, but the only changes here are to convert "UTF8"
to "base::ASCII" and convert references to now-removed locals to use accessors.

[Mark P, 2016-06-08 21:41:40]

lgtm

https://codereview.chromium.org/2048693003/diff/1/components/omnibox/browser/...
File components/omnibox/browser/omnibox_edit_unittest.cc (right):

https://codereview.chromium.org/2048693003/diff/1/components/omnibox/browser/...
components/omnibox/browser/omnibox_edit_unittest.cc:254: const
TestingOmniboxView& view() { return view_; }
nit: It looks a little weird that you've chosen to return a const reference here
rather than a regular pointer as above and below.  Any particular reason other
than "that's all we need"?

[Peter Kasting, 2016-06-08 21:46:42]

https://codereview.chromium.org/2048693003/diff/1/components/omnibox/browser/...
File components/omnibox/browser/omnibox_edit_unittest.cc (right):

https://codereview.chromium.org/2048693003/diff/1/components/omnibox/browser/...
components/omnibox/browser/omnibox_edit_unittest.cc:254: const
TestingOmniboxView& view() { return view_; }
On 2016/06/08 21:41:40, Mark P wrote:
> nit: It looks a little weird that you've chosen to return a const reference
here
> rather than a regular pointer as above and below.  Any particular reason other
> than "that's all we need"?

I thought about returning a const pointer but it seemed like we normally use
const refs in preference when they would work (i.e. when the return value cannot
be null).

I didn't want to return something non-const, since the caller only needs
something const.

[Peter Kasting, 2016-06-08 21:47:05]

The CQ bit was checked by pkasting@chromium.org

[commit-bot: I haz the power, 2016-06-08 21:47:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2048693003/1

[commit-bot: I haz the power, 2016-06-08 21:56:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-08 21:56:43]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Peter Kasting, 2016-06-09 19:20:27]

The CQ bit was checked by pkasting@chromium.org

[Peter Kasting, 2016-06-09 19:20:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
mpearson@chromium.org
Link to the patchset: https://codereview.chromium.org/2048693003/#ps20001
(title: "Resync")

[commit-bot: I haz the power, 2016-06-09 19:20:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2048693003/20001

[commit-bot: I haz the power, 2016-06-09 20:31:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-09 20:33:07]

Description was changed from

==========
Misc. omnibox cleanup:

* NULL -> nullptr
* unix_hacker()-style functions should be inlined
* Add convenience wrapper in OmniboxEditModel for popup IsOpen() checks and use
  it everywhere (this results in us adding null checks in a few places that
  didn't have them, which is necessary for an upcoming change)
* UTF8ToUTF16() -> ASCIIToUTF16()
* Avoid using directives
* Collapse common setup in edit unittests into the test base class

BUG=none
TEST=none
==========

to

==========
Misc. omnibox cleanup:

* NULL -> nullptr
* unix_hacker()-style functions should be inlined
* Add convenience wrapper in OmniboxEditModel for popup IsOpen() checks and use
  it everywhere (this results in us adding null checks in a few places that
  didn't have them, which is necessary for an upcoming change)
* UTF8ToUTF16() -> ASCIIToUTF16()
* Avoid using directives
* Collapse common setup in edit unittests into the test base class

BUG=none
TEST=none

Committed: https://crrev.com/5c074479ad4691cda5033a909d33727572c7997b
Cr-Commit-Position: refs/heads/master@{#398999}
==========

[commit-bot: I haz the power, 2016-06-09 20:33:08]

Patchset 2 (id:??) landed as
https://crrev.com/5c074479ad4691cda5033a909d33727572c7997b
Cr-Commit-Position: refs/heads/master@{#398999}