components/omnibox/browser/omnibox_controller.cc - Issue 2048693003: Misc. omnibox cleanup:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/omnibox/browser/omnibox_controller.cc

Issue 2048693003: Misc. omnibox cleanup: (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Resync Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/omnibox/browser/omnibox_controller.cc

diff --git a/components/omnibox/browser/omnibox_controller.cc b/components/omnibox/browser/omnibox_controller.cc

index 9cbe634dfc8eb0eabfeb49ddcdda3118a69f90ec..9b5b84ae48372d696b2cedca1345e34dde4ccfd6 100644

--- a/components/omnibox/browser/omnibox_controller.cc

+++ b/components/omnibox/browser/omnibox_controller.cc

@@ -19,7 +19,7 @@ OmniboxController::OmniboxController(OmniboxEditModel* omnibox_edit_model,

OmniboxClient* client)

: omnibox_edit_model_(omnibox_edit_model),

client_(client),

- popup_(NULL),

+ popup_(nullptr),

autocomplete_controller_(new AutocompleteController(

client_->CreateAutocompleteProviderClient(),

this,

@@ -51,7 +51,7 @@ void OmniboxController::OnResultChanged(bool default_match_changed) {

} else {

InvalidateCurrentMatch();

popup_->OnResultChanged();

- omnibox_edit_model_->OnPopupDataChanged(base::string16(), NULL,

+ omnibox_edit_model_->OnPopupDataChanged(base::string16(), nullptr,

base::string16(), false);

}

} else {