Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2048673002: Revert of Replace ui::LatencyInfo::InputCoordinate with gfx::PointF (Closed)

Created:
4 years, 6 months ago by Geoff Lang
Modified:
4 years, 6 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, tdresser+watch_chromium.org, viettrungluu+watch_chromium.org, jam, dtapuska+chromiumwatch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, yzshen+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Replace ui::LatencyInfo::InputCoordinate with gfx::PointF (patchset #6 id:90001 of https://codereview.chromium.org/2039853004/ ) Reason for revert: This appears to have broken the Windows GPU debug builder. First broken build: https://build.chromium.org/p/chromium.gpu.fyi/builders/GPU%20Win%20Builder%20%28dbg%29/builds/40788 Original issue's description: > Replace ui::LatencyInfo::InputCoordinate with gfx::PointF > > This reduces code duplication and makes the world a happier place. > > BUG=611802 > TBR=ben@chromium.org > > Committed: https://crrev.com/cc016ede169b3f1a9d7153a27eadd6d8ead52e1a > Cr-Commit-Position: refs/heads/master@{#398278} TBR=sadrul@chromium.org,tsepez@chromium.org,ben@chromium.org,fsamuel@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=611802 Committed: https://crrev.com/4a11f31975f19c063f4d42da0b5feae678188d9d Cr-Commit-Position: refs/heads/master@{#398308}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+144 lines, -65 lines) Patch
M content/browser/renderer_host/input/render_widget_host_latency_tracker.cc View 2 chunks +12 lines, -8 lines 0 comments Download
M content/browser/renderer_host/input/render_widget_host_latency_tracker_unittest.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M tools/ipc_fuzzer/fuzzer/fuzzer.cc View 2 chunks +14 lines, -1 line 0 comments Download
M ui/events/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/events.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/events_unittests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/ipc/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/ipc/latency_info_param_traits.cc View 2 chunks +1 line, -3 lines 0 comments Download
M ui/events/ipc/latency_info_param_traits_macros.h View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/events/ipc/latency_info_param_traits_unittest.cc View 4 chunks +11 lines, -9 lines 0 comments Download
M ui/events/latency_info.h View 4 chunks +13 lines, -4 lines 0 comments Download
M ui/events/latency_info.cc View 3 chunks +9 lines, -3 lines 0 comments Download
M ui/events/mojo/BUILD.gn View 2 chunks +1 line, -1 line 0 comments Download
M ui/events/mojo/latency_info.mojom View 2 chunks +8 lines, -2 lines 0 comments Download
M ui/events/mojo/latency_info.typemap View 1 chunk +1 line, -1 line 0 comments Download
M ui/events/mojo/latency_info_struct_traits.h View 1 chunk +19 lines, -3 lines 0 comments Download
M ui/events/mojo/latency_info_struct_traits.cc View 2 chunks +10 lines, -9 lines 0 comments Download
M ui/events/mojo/struct_traits_unittest.cc View 4 chunks +27 lines, -7 lines 0 comments Download
M ui/events/mojo/traits_test_service.mojom View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Geoff Lang
Created Revert of Replace ui::LatencyInfo::InputCoordinate with gfx::PointF
4 years, 6 months ago (2016-06-07 15:42:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2048673002/1
4 years, 6 months ago (2016-06-07 15:42:53 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 15:44:00 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 15:45:37 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4a11f31975f19c063f4d42da0b5feae678188d9d
Cr-Commit-Position: refs/heads/master@{#398308}

Powered by Google App Engine
This is Rietveld 408576698