Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Side by Side Diff: ui/events/ipc/latency_info_param_traits_unittest.cc

Issue 2048673002: Revert of Replace ui::LatencyInfo::InputCoordinate with gfx::PointF (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/events/ipc/latency_info_param_traits_macros.h ('k') | ui/events/latency_info.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 #include <stdint.h> 6 #include <stdint.h>
7 7
8 #include "ipc/ipc_message_macros.h" 8 #include "ipc/ipc_message_macros.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 #include "ui/events/ipc/latency_info_param_traits.h" 10 #include "ui/events/ipc/latency_info_param_traits.h"
11 #include "ui/events/ipc/latency_info_param_traits_macros.h" 11 #include "ui/events/ipc/latency_info_param_traits_macros.h"
12 #include "ui/gfx/ipc/geometry/gfx_param_traits.h"
13 12
14 namespace ui { 13 namespace ui {
15 14
16 TEST(LatencyInfoParamTraitsTest, Basic) { 15 TEST(LatencyInfoParamTraitsTest, Basic) {
17 LatencyInfo latency; 16 LatencyInfo latency;
18 ASSERT_FALSE(latency.terminated()); 17 ASSERT_FALSE(latency.terminated());
19 ASSERT_EQ(0u, latency.input_coordinates_size()); 18 ASSERT_EQ(0u, latency.input_coordinates_size());
20 latency.AddLatencyNumber(INPUT_EVENT_LATENCY_ORIGINAL_COMPONENT, 1234, 0); 19 latency.AddLatencyNumber(INPUT_EVENT_LATENCY_ORIGINAL_COMPONENT, 1234, 0);
21 latency.AddLatencyNumber(INPUT_EVENT_LATENCY_BEGIN_RWH_COMPONENT, 1234, 100); 20 latency.AddLatencyNumber(INPUT_EVENT_LATENCY_BEGIN_RWH_COMPONENT, 1234, 100);
22 latency.AddLatencyNumber(INPUT_EVENT_LATENCY_TERMINATED_FRAME_SWAP_COMPONENT, 21 latency.AddLatencyNumber(INPUT_EVENT_LATENCY_TERMINATED_FRAME_SWAP_COMPONENT,
23 1234, 0); 22 1234, 0);
24 EXPECT_TRUE(latency.AddInputCoordinate(gfx::PointF(100, 200))); 23 EXPECT_TRUE(latency.AddInputCoordinate(
25 EXPECT_TRUE(latency.AddInputCoordinate(gfx::PointF(101, 201))); 24 LatencyInfo::InputCoordinate(100, 200)));
25 EXPECT_TRUE(latency.AddInputCoordinate(
26 LatencyInfo::InputCoordinate(101, 201)));
26 // Up to 2 InputCoordinate is allowed. 27 // Up to 2 InputCoordinate is allowed.
27 EXPECT_FALSE(latency.AddInputCoordinate(gfx::PointF(102, 202))); 28 EXPECT_FALSE(latency.AddInputCoordinate(
29 LatencyInfo::InputCoordinate(102, 202)));
28 30
29 EXPECT_EQ(100, latency.trace_id()); 31 EXPECT_EQ(100, latency.trace_id());
30 EXPECT_TRUE(latency.terminated()); 32 EXPECT_TRUE(latency.terminated());
31 EXPECT_EQ(2u, latency.input_coordinates_size()); 33 EXPECT_EQ(2u, latency.input_coordinates_size());
32 34
33 IPC::Message msg(1, 2, IPC::Message::PRIORITY_NORMAL); 35 IPC::Message msg(1, 2, IPC::Message::PRIORITY_NORMAL);
34 IPC::WriteParam(&msg, latency); 36 IPC::WriteParam(&msg, latency);
35 base::PickleIterator iter(msg); 37 base::PickleIterator iter(msg);
36 LatencyInfo output; 38 LatencyInfo output;
37 EXPECT_TRUE(IPC::ReadParam(&msg, &iter, &output)); 39 EXPECT_TRUE(IPC::ReadParam(&msg, &iter, &output));
38 40
39 EXPECT_EQ(latency.trace_id(), output.trace_id()); 41 EXPECT_EQ(latency.trace_id(), output.trace_id());
40 EXPECT_EQ(latency.terminated(), output.terminated()); 42 EXPECT_EQ(latency.terminated(), output.terminated());
41 EXPECT_EQ(latency.input_coordinates_size(), output.input_coordinates_size()); 43 EXPECT_EQ(latency.input_coordinates_size(), output.input_coordinates_size());
42 for (size_t i = 0; i < latency.input_coordinates_size(); i++) { 44 for (size_t i = 0; i < latency.input_coordinates_size(); i++) {
43 EXPECT_EQ(latency.input_coordinates()[i].x(), 45 EXPECT_EQ(latency.input_coordinates()[i].x,
44 output.input_coordinates()[i].x()); 46 output.input_coordinates()[i].x);
45 EXPECT_EQ(latency.input_coordinates()[i].y(), 47 EXPECT_EQ(latency.input_coordinates()[i].y,
46 output.input_coordinates()[i].y()); 48 output.input_coordinates()[i].y);
47 } 49 }
48 50
49 EXPECT_TRUE(output.FindLatency(INPUT_EVENT_LATENCY_ORIGINAL_COMPONENT, 51 EXPECT_TRUE(output.FindLatency(INPUT_EVENT_LATENCY_ORIGINAL_COMPONENT,
50 1234, 52 1234,
51 nullptr)); 53 nullptr));
52 54
53 LatencyInfo::LatencyComponent rwh_comp; 55 LatencyInfo::LatencyComponent rwh_comp;
54 EXPECT_TRUE(output.FindLatency(INPUT_EVENT_LATENCY_BEGIN_RWH_COMPONENT, 56 EXPECT_TRUE(output.FindLatency(INPUT_EVENT_LATENCY_BEGIN_RWH_COMPONENT,
55 1234, 57 1234,
56 &rwh_comp)); 58 &rwh_comp));
57 EXPECT_EQ(100, rwh_comp.sequence_number); 59 EXPECT_EQ(100, rwh_comp.sequence_number);
58 EXPECT_EQ(1u, rwh_comp.event_count); 60 EXPECT_EQ(1u, rwh_comp.event_count);
59 61
60 EXPECT_TRUE(output.FindLatency( 62 EXPECT_TRUE(output.FindLatency(
61 INPUT_EVENT_LATENCY_TERMINATED_FRAME_SWAP_COMPONENT, 1234, nullptr)); 63 INPUT_EVENT_LATENCY_TERMINATED_FRAME_SWAP_COMPONENT, 1234, nullptr));
62 } 64 }
63 65
64 TEST(LatencyInfoParamTraitsTest, InvalidData) { 66 TEST(LatencyInfoParamTraitsTest, InvalidData) {
65 IPC::Message msg(1, 2, IPC::Message::PRIORITY_NORMAL); 67 IPC::Message msg(1, 2, IPC::Message::PRIORITY_NORMAL);
66 IPC::WriteParam(&msg, std::string()); 68 IPC::WriteParam(&msg, std::string());
67 ui::LatencyInfo::LatencyMap components; 69 ui::LatencyInfo::LatencyMap components;
68 IPC::WriteParam(&msg, components); 70 IPC::WriteParam(&msg, components);
69 // input_coordinates_size is 2 but only one InputCoordinate is written. 71 // input_coordinates_size is 2 but only one InputCoordinate is written.
70 IPC::WriteParam(&msg, static_cast<uint32_t>(2)); 72 IPC::WriteParam(&msg, static_cast<uint32_t>(2));
71 IPC::WriteParam(&msg, gfx::PointF()); 73 IPC::WriteParam(&msg, ui::LatencyInfo::InputCoordinate());
72 IPC::WriteParam(&msg, static_cast<int64_t>(1234)); 74 IPC::WriteParam(&msg, static_cast<int64_t>(1234));
73 IPC::WriteParam(&msg, true); 75 IPC::WriteParam(&msg, true);
74 76
75 base::PickleIterator iter(msg); 77 base::PickleIterator iter(msg);
76 LatencyInfo output; 78 LatencyInfo output;
77 EXPECT_FALSE(IPC::ReadParam(&msg, &iter, &output)); 79 EXPECT_FALSE(IPC::ReadParam(&msg, &iter, &output));
78 } 80 }
79 81
80 } // namespace ui 82 } // namespace ui
OLDNEW
« no previous file with comments | « ui/events/ipc/latency_info_param_traits_macros.h ('k') | ui/events/latency_info.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698