[Password Generation] Handle DidFinishLoad event in PasswordGenerationAgent as well

[Password Generation] Handle not only DidFinishDocumentLoad in PasswordGenerationAgent, but also DidFinishLoad

DidFinishDocumentLoad event happens too early, i.e. some forms might be still unavailable. For example, if some Javascript stuff is involved. See https://cs.chromium.org/chromium/src/third_party/WebKit/public/web/WebFrameClient.h. DidFinishDocumentLoad is triggered before Javascript work. The solution is to handle DidFinishLoad that is triggered after Javascript work.

This bug (crbug.com/452741) points that the processing DidFinishDocumentLoad is also necessary. So, this CL introduces handling both events (DidFinishDocumentLoad and DidFinishLoad)

There are no tests for the given change, because it is very hard to catch the difference between DidFinishDocumentLoad and DidFinishLoad. Even if it is possible, the test will be probably flaky.

BUG=617893
Committed: https://crrev.com/c2fd8ecef7c96e060d601ef71894846164581c9a
Cr-Commit-Position: refs/heads/master@{#398509}

[kolos1, 2016-06-07 09:11:30]

Description was changed from

==========
[Password Generation] Initialize PasswordGenerationAgent on DidFinishLoad, but
not on DidFinishDocumentLoad

DidFinishDocumentLoad event happens too early, i.e. some forms might be still
unavailable. For example, if some Javascript stuff is involved. See
https://cs.chromium.org/chromium/src/third_party/WebKit/public/web/WebFrameCl....
DidFinishDocumentLoad is triggered before Javascript work.

BUG=
==========

to

==========
[Password Generation] Initialize PasswordGenerationAgent on DidFinishLoad, but
not on DidFinishDocumentLoad

DidFinishDocumentLoad event happens too early, i.e. some forms might be still
unavailable. For example, if some Javascript stuff is involved. See
https://cs.chromium.org/chromium/src/third_party/WebKit/public/web/WebFrameCl....
DidFinishDocumentLoad is triggered before Javascript work.

BUG=617893
==========

[kolos1, 2016-06-07 10:43:13]

Patchset #3 (id:40001) has been deleted

[kolos1, 2016-06-07 15:16:52]

Description was changed from

==========
[Password Generation] Initialize PasswordGenerationAgent on DidFinishLoad, but
not on DidFinishDocumentLoad

DidFinishDocumentLoad event happens too early, i.e. some forms might be still
unavailable. For example, if some Javascript stuff is involved. See
https://cs.chromium.org/chromium/src/third_party/WebKit/public/web/WebFrameCl....
DidFinishDocumentLoad is triggered before Javascript work.

BUG=617893
==========

to

==========
[Password Generation] Handle not only DidFinishDocumentLoad in 
PasswordGenerationAgent, but also DidFinishLoad

DidFinishDocumentLoad event happens too early, i.e. some forms might be still
unavailable. For example, if some Javascript stuff is involved. See
https://cs.chromium.org/chromium/src/third_party/WebKit/public/web/WebFrameCl....
DidFinishDocumentLoad is triggered before Javascript work.

This CL introduces handling both events (DidFinishDocumentLoad and
DidFinishLoad)

BUG=617893
==========

[kolos1, 2016-06-08 07:12:14]

Description was changed from

==========
[Password Generation] Handle not only DidFinishDocumentLoad in 
PasswordGenerationAgent, but also DidFinishLoad

DidFinishDocumentLoad event happens too early, i.e. some forms might be still
unavailable. For example, if some Javascript stuff is involved. See
https://cs.chromium.org/chromium/src/third_party/WebKit/public/web/WebFrameCl....
DidFinishDocumentLoad is triggered before Javascript work.

This CL introduces handling both events (DidFinishDocumentLoad and
DidFinishLoad)

BUG=617893
==========

to

==========
[Password Generation] Handle not only DidFinishDocumentLoad in 
PasswordGenerationAgent, but also DidFinishLoad

DidFinishDocumentLoad event happens too early, i.e. some forms might be still
unavailable. For example, if some Javascript stuff is involved. See
https://cs.chromium.org/chromium/src/third_party/WebKit/public/web/WebFrameCl....
DidFinishDocumentLoad is triggered before Javascript work. The solution is to
handle DidFinishLoad that is triggered after Javascript work.

This bug (crbug.com/452741) points that the processing DidFinishDocumentLoad is
also necessary. So, this CL introduces handling both events
(DidFinishDocumentLoad and DidFinishLoad)

There are no tests for the given change, because it is very hard to catch the
difference between DidFinishDocumentLoad and DidFinishLoad. Even it is possible,
the test will be probably flaky. 

BUG=617893
==========

[kolos1, 2016-06-08 07:12:41]

Description was changed from

==========
[Password Generation] Handle not only DidFinishDocumentLoad in 
PasswordGenerationAgent, but also DidFinishLoad

DidFinishDocumentLoad event happens too early, i.e. some forms might be still
unavailable. For example, if some Javascript stuff is involved. See
https://cs.chromium.org/chromium/src/third_party/WebKit/public/web/WebFrameCl....
DidFinishDocumentLoad is triggered before Javascript work. The solution is to
handle DidFinishLoad that is triggered after Javascript work.

This bug (crbug.com/452741) points that the processing DidFinishDocumentLoad is
also necessary. So, this CL introduces handling both events
(DidFinishDocumentLoad and DidFinishLoad)

There are no tests for the given change, because it is very hard to catch the
difference between DidFinishDocumentLoad and DidFinishLoad. Even it is possible,
the test will be probably flaky. 

BUG=617893
==========

to

==========
[Password Generation] Handle not only DidFinishDocumentLoad in
PasswordGenerationAgent, but also DidFinishLoad

DidFinishDocumentLoad event happens too early, i.e. some forms might be still
unavailable. For example, if some Javascript stuff is involved. See
https://cs.chromium.org/chromium/src/third_party/WebKit/public/web/WebFrameCl....
DidFinishDocumentLoad is triggered before Javascript work. The solution is to
handle DidFinishLoad that is triggered after Javascript work.

This bug (crbug.com/452741) points that the processing DidFinishDocumentLoad is
also necessary. So, this CL introduces handling both events
(DidFinishDocumentLoad and DidFinishLoad)

There are no tests for the given change, because it is very hard to catch the
difference between DidFinishDocumentLoad and DidFinishLoad. Even it is possible,
the test will be probably flaky. 

BUG=617893
==========

[kolos1, 2016-06-08 07:18:37]

kolos@chromium.org changed reviewers:
+ vabr@chromium.org

[kolos1, 2016-06-08 07:18:38]

Hi Vaclav,

Please review this CL on improving form detection for Password Generation. 

Regards,
Maxim

[kolos1, 2016-06-08 07:19:39]

Description was changed from

==========
[Password Generation] Handle not only DidFinishDocumentLoad in
PasswordGenerationAgent, but also DidFinishLoad

DidFinishDocumentLoad event happens too early, i.e. some forms might be still
unavailable. For example, if some Javascript stuff is involved. See
https://cs.chromium.org/chromium/src/third_party/WebKit/public/web/WebFrameCl....
DidFinishDocumentLoad is triggered before Javascript work. The solution is to
handle DidFinishLoad that is triggered after Javascript work.

This bug (crbug.com/452741) points that the processing DidFinishDocumentLoad is
also necessary. So, this CL introduces handling both events
(DidFinishDocumentLoad and DidFinishLoad)

There are no tests for the given change, because it is very hard to catch the
difference between DidFinishDocumentLoad and DidFinishLoad. Even it is possible,
the test will be probably flaky. 

BUG=617893
==========

to

==========
[Password Generation] Handle not only DidFinishDocumentLoad in
PasswordGenerationAgent, but also DidFinishLoad

DidFinishDocumentLoad event happens too early, i.e. some forms might be still
unavailable. For example, if some Javascript stuff is involved. See
https://cs.chromium.org/chromium/src/third_party/WebKit/public/web/WebFrameCl....
DidFinishDocumentLoad is triggered before Javascript work. The solution is to
handle DidFinishLoad that is triggered after Javascript work.

This bug (crbug.com/452741) points that the processing DidFinishDocumentLoad is
also necessary. So, this CL introduces handling both events
(DidFinishDocumentLoad and DidFinishLoad)

There are no tests for the given change, because it is very hard to catch the
difference between DidFinishDocumentLoad and DidFinishLoad. Even if it is
possible, the test will be probably flaky. 

BUG=617893
==========

[vabr (Chromium), 2016-06-08 07:54:36]

LGTM, this seems reasonable.
Thanks!
Vaclav

[kolos1, 2016-06-08 08:08:45]

The CQ bit was checked by kolos@chromium.org

[commit-bot: I haz the power, 2016-06-08 08:09:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2048603002/120001

[commit-bot: I haz the power, 2016-06-08 09:39:57]

Description was changed from

==========
[Password Generation] Handle not only DidFinishDocumentLoad in
PasswordGenerationAgent, but also DidFinishLoad

DidFinishDocumentLoad event happens too early, i.e. some forms might be still
unavailable. For example, if some Javascript stuff is involved. See
https://cs.chromium.org/chromium/src/third_party/WebKit/public/web/WebFrameCl....
DidFinishDocumentLoad is triggered before Javascript work. The solution is to
handle DidFinishLoad that is triggered after Javascript work.

This bug (crbug.com/452741) points that the processing DidFinishDocumentLoad is
also necessary. So, this CL introduces handling both events
(DidFinishDocumentLoad and DidFinishLoad)

There are no tests for the given change, because it is very hard to catch the
difference between DidFinishDocumentLoad and DidFinishLoad. Even if it is
possible, the test will be probably flaky. 

BUG=617893
==========

to

==========
[Password Generation] Handle not only DidFinishDocumentLoad in
PasswordGenerationAgent, but also DidFinishLoad

DidFinishDocumentLoad event happens too early, i.e. some forms might be still
unavailable. For example, if some Javascript stuff is involved. See
https://cs.chromium.org/chromium/src/third_party/WebKit/public/web/WebFrameCl....
DidFinishDocumentLoad is triggered before Javascript work. The solution is to
handle DidFinishLoad that is triggered after Javascript work.

This bug (crbug.com/452741) points that the processing DidFinishDocumentLoad is
also necessary. So, this CL introduces handling both events
(DidFinishDocumentLoad and DidFinishLoad)

There are no tests for the given change, because it is very hard to catch the
difference between DidFinishDocumentLoad and DidFinishLoad. Even if it is
possible, the test will be probably flaky. 

BUG=617893
==========

[commit-bot: I haz the power, 2016-06-08 09:39:58]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2016-06-08 09:40:55]

Description was changed from

==========
[Password Generation] Handle not only DidFinishDocumentLoad in
PasswordGenerationAgent, but also DidFinishLoad

DidFinishDocumentLoad event happens too early, i.e. some forms might be still
unavailable. For example, if some Javascript stuff is involved. See
https://cs.chromium.org/chromium/src/third_party/WebKit/public/web/WebFrameCl....
DidFinishDocumentLoad is triggered before Javascript work. The solution is to
handle DidFinishLoad that is triggered after Javascript work.

This bug (crbug.com/452741) points that the processing DidFinishDocumentLoad is
also necessary. So, this CL introduces handling both events
(DidFinishDocumentLoad and DidFinishLoad)

There are no tests for the given change, because it is very hard to catch the
difference between DidFinishDocumentLoad and DidFinishLoad. Even if it is
possible, the test will be probably flaky. 

BUG=617893
==========

to

==========
[Password Generation] Handle not only DidFinishDocumentLoad in
PasswordGenerationAgent, but also DidFinishLoad

DidFinishDocumentLoad event happens too early, i.e. some forms might be still
unavailable. For example, if some Javascript stuff is involved. See
https://cs.chromium.org/chromium/src/third_party/WebKit/public/web/WebFrameCl....
DidFinishDocumentLoad is triggered before Javascript work. The solution is to
handle DidFinishLoad that is triggered after Javascript work.

This bug (crbug.com/452741) points that the processing DidFinishDocumentLoad is
also necessary. So, this CL introduces handling both events
(DidFinishDocumentLoad and DidFinishLoad)

There are no tests for the given change, because it is very hard to catch the
difference between DidFinishDocumentLoad and DidFinishLoad. Even if it is
possible, the test will be probably flaky.

BUG=617893

Committed: https://crrev.com/c2fd8ecef7c96e060d601ef71894846164581c9a
Cr-Commit-Position: refs/heads/master@{#398509}
==========

[commit-bot: I haz the power, 2016-06-08 09:40:56]

Patchset 6 (id:??) landed as
https://crrev.com/c2fd8ecef7c96e060d601ef71894846164581c9a
Cr-Commit-Position: refs/heads/master@{#398509}