Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2068)

Unified Diff: components/autofill/content/renderer/password_generation_agent.cc

Issue 2048603002: [Password Generation] Handle DidFinishLoad event in PasswordGenerationAgent as well (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/autofill/content/renderer/password_generation_agent.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/content/renderer/password_generation_agent.cc
diff --git a/components/autofill/content/renderer/password_generation_agent.cc b/components/autofill/content/renderer/password_generation_agent.cc
index 331fcc1f59478d35a2c83559f532f63954c8c59d..33c30aa55eda15f9cb792d15ced9e9837c4dfcab 100644
--- a/components/autofill/content/renderer/password_generation_agent.cc
+++ b/components/autofill/content/renderer/password_generation_agent.cc
@@ -179,6 +179,13 @@ void PasswordGenerationAgent::DidFinishDocumentLoad() {
FindPossibleGenerationForm();
}
+void PasswordGenerationAgent::DidFinishLoad() {
+ // Since forms on some sites are available only at this event (but not at
+ // DidFinishDocumentLoad), again call FindPossibleGenerationForm to detect
+ // these forms (crbug.com/617893).
+ FindPossibleGenerationForm();
+}
+
void PasswordGenerationAgent::OnDestruct() {
base::ThreadTaskRunnerHandle::Get()->DeleteSoon(FROM_HERE, this);
}
« no previous file with comments | « components/autofill/content/renderer/password_generation_agent.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698