Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6599)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/native_library_mac.mm

Issue 2048523002: Fix base::GetNativeLibraryName() for Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@native_lib_clean
Patch Set: Address comments, merge variables. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/native_library_ios.mm ('k') | base/native_library_posix.cc » ('j') | base/scoped_native_library_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/native_library_mac.mm
diff --git a/base/native_library_mac.mm b/base/native_library_mac.mm
index f7eeba3e7e208057872ced882f5b75e707b2acfd..2cf7f85b3532d2eda8e07bff15da4f334d53fadb 100644
--- a/base/native_library_mac.mm
+++ b/base/native_library_mac.mm
@@ -118,8 +118,8 @@ void* GetFunctionPointerFromNativeLibrary(NativeLibrary library,
}
// static
-string16 GetNativeLibraryName(StringPiece16 name) {
- return name.as_string() + ASCIIToUTF16(".dylib");
+std::string GetNativeLibraryName(StringPiece name) {
+ return "lib" + name.as_string() + ".dylib";
}
} // namespace base
« no previous file with comments | « base/native_library_ios.mm ('k') | base/native_library_posix.cc » ('j') | base/scoped_native_library_unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698