base/scoped_native_library_unittest.cc - Issue 2048523002: Fix base::GetNativeLibraryName() for Mac.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/scoped_native_library_unittest.cc

Issue 2048523002: Fix base::GetNativeLibraryName() for Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@native_lib_clean

Patch Set: Address comments, merge variables. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « base/profiler/stack_sampling_profiler_unittest.cc ('k') | chrome/browser/component_updater/widevine_cdm_component_installer.cc » ('j') | net/udp/udp_socket_posix.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/scoped_native_library_unittest.cc

diff --git a/base/scoped_native_library_unittest.cc b/base/scoped_native_library_unittest.cc

index 204aadb983e07cfe51ae8dd0f07d93690d31d84b..d072e31c02dc40ffb198e2b9d4f680004062ce01 100644

--- a/base/scoped_native_library_unittest.cc

+++ b/base/scoped_native_library_unittest.cc

@@ -9,6 +9,7 @@

#if defined(OS_WIN)

#include "base/files/file_path.h"

+#include "base/strings/utf_string_conversions.h"

#endif

namespace base {

@@ -27,7 +28,7 @@ TEST(ScopedNativeLibrary, Basic) {

const char kFunctionName[] = "DirectDrawCreate";

NativeLibrary native_library;

{

- FilePath path(GetNativeLibraryName(L"ddraw"));

+ FilePath path(base::ASCIIToUTF16(GetNativeLibraryName("ddraw")));

Mark Mentovai 2016/06/13 19:29:03 FilePath::FromUTF16Unsafe()?

Lei Zhang 2016/06/13 21:30:34 I might as well skip the ASCIIToUTF16() bit and us

native_library = LoadNativeLibrary(path, NULL);

ScopedNativeLibrary library(native_library);

EXPECT_TRUE(library.is_valid());